4.3 KiB
Vitest Contributing Guide
Hi! We are really excited that you are interested in contributing to Vitest. Before submitting your contribution, please make sure to take a moment and read through the following guide:
Repo Setup
The Vitest repo is a monorepo using pnpm workspaces. The package manager used to install and link dependencies must be pnpm.
We recommend installing ni to help switching between repos using different package managers. ni also provides the handy nr command which running npm scripts easier:
niis equivalent topnpm installnr testis equivalent topnpm run test
To develop and test vitest package:
-
Run
pnpm iinvitest's root folder -
Run
pnpm run devto build sources in watch mode -
Run
pnpm run testto run core testspnpm run test:allto run all the suite
Debugging
VS Code
If you want to use break point and explore code execution you can use the "Run and debug" feature from vscode.
-
Add a
debuggerstatement where you want to stop the code execution. -
Click on the "Run and Debug" icon in the activity bar of the editor.
-
Click on the "Javascript Debug Terminal" button.
-
It will open a terminal, then type the test command:
pnpm run test -
The execution will stop and you'll use the Debug toolbar to continue, step over, restart the process...
Testing Vite against external packages
You may wish to test your locally-modified copy of Vitest against another package that is using it. For pnpm, after building Vitest, you can use pnpm.overrides. Please note that pnpm.overrides must be specified in the root package.json and you must first list the package as a dependency in the root package.json:
{
"dependencies": {
"vite": "^2.0.0"
},
"pnpm": {
"overrides": {
"vitest": "link:../path/to/vitest/packages/vitest"
}
}
}
And re-run pnpm i to link the package.
Pull Request Guidelines
-
Checkout a topic branch from a base branch, e.g.
main, and merge back against that branch. -
If adding a new feature:
- Add accompanying test case.
- Provide a convincing reason to add this feature. Ideally, you should open a suggestion issue first and have it approved before working on it.
-
If fixing bug:
- If you are resolving a special issue, add
(fix #xxxx[,#xxxx])(#xxxx is the issue id) in your PR title for a better release log, e.g.fix: update entities encoding/decoding (fix #3899). - Provide a detailed description of the bug in the PR. Live demo preferred.
- Add appropriate test coverage if applicable.
- If you are resolving a special issue, add
-
It's OK to have multiple small commits as you work on the PR - GitHub can automatically squash them before merging.
-
Make sure tests pass!
-
Commit messages must follow the commit message convention so that changelogs can be automatically generated.
-
Use
pnpm run lint:fixto format files according to the project guidelines.
Notes on Dependencies
Vitest aims to be lightweight, and this includes being aware of the number of npm dependencies and their size.
Think before adding a dependency
Most deps should be added to devDependencies even if they are needed at runtime. Some exceptions are:
- Type packages. Example:
@types/*. - Deps that cannot be properly bundled due to binary files.
- Deps that ships its own types and its type is used in vitest's own public types.
Avoid deps that has large transitive dependencies that results in bloated size compared to the functionality it provides.
If there are libraries that are needed and don't comply with our size requirements, a fork can be tried to reduce its size while we work with them to upstream our changes (see tinypool for example)
Think before adding yet another option
We already have many config options, and we should avoid fixing an issue by adding yet another one. Before adding an option, try to think about:
- Whether the problem is really worth addressing
- Whether the problem can be fixed with a smarter default
- Whether the problem has workaround using existing options
- Whether the problem can be addressed with a plugin instead