mirror of
https://github.com/tailwindlabs/tailwindcss.git
synced 2025-12-08 21:36:08 +00:00
6496 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Philipp Spiess
|
8e00c01a1d | Add reference CSS coverage for parser | ||
depfu[bot]
|
4827c465b8
|
Update @emnapi/core 1.5.0 → 1.6.0 (minor) (#19220)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @emnapi/core (1.5.0 → 1.6.0) · [Repo](https://github.com/toyobayashi/emnapi) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/toyobayashi/emnapi/releases/tag/v1.6.0">1.6.0</a></h4> <blockquote><h2 dir="auto">What's Changed</h2> <ul dir="auto"> <li>feat: added SharedArrayBuffer api by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/171">#171</a> </li> <li>feat: make napi_delete_reference use node_api_basic_env by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/170">#170</a> </li> <li>ci: migrate to npm trusted publishing by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/168">#168</a> </li> </ul> <p dir="auto"><strong>Full Changelog</strong>: <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/compare/v1.5.0...v1.6.0"><tt>v1.5.0...v1.6.0</tt></a></p></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/@emnapi%2Fcore/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href=" |
||
|
depfu[bot]
|
4aa763b2a3
|
Update emnapi 1.5.0 → 1.6.0 (minor) (#19221)
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ emnapi (1.5.0 → 1.6.0) · [Repo](https://github.com/toyobayashi/emnapi) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/toyobayashi/emnapi/releases/tag/v1.6.0">1.6.0</a></h4> <blockquote><h2 dir="auto">What's Changed</h2> <ul dir="auto"> <li>feat: added SharedArrayBuffer api by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/171">#171</a> </li> <li>feat: make napi_delete_reference use node_api_basic_env by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/170">#170</a> </li> <li>ci: migrate to npm trusted publishing by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/168">#168</a> </li> </ul> <p dir="auto"><strong>Full Changelog</strong>: <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/compare/v1.5.0...v1.6.0"><tt>v1.5.0...v1.6.0</tt></a></p></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/emnapi/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href=" |
||
|
depfu[bot]
|
7bab613749
|
Update @emnapi/runtime 1.5.0 → 1.6.0 (minor) (#19219)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @emnapi/runtime (1.5.0 → 1.6.0) · [Repo](https://github.com/toyobayashi/emnapi) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/toyobayashi/emnapi/releases/tag/v1.6.0">1.6.0</a></h4> <blockquote><h2 dir="auto">What's Changed</h2> <ul dir="auto"> <li>feat: added SharedArrayBuffer api by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/171">#171</a> </li> <li>feat: make napi_delete_reference use node_api_basic_env by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/170">#170</a> </li> <li>ci: migrate to npm trusted publishing by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/168">#168</a> </li> </ul> <p dir="auto"><strong>Full Changelog</strong>: <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/compare/v1.5.0...v1.6.0"><tt>v1.5.0...v1.6.0</tt></a></p></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/@emnapi%2Fruntime/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href=" |
||
|
depfu[bot]
|
91694fbfc1 | Update @playwright/test to version 1.56.1 | ||
|
depfu[bot]
|
effcd27e17
|
Update all of nextjs 15.5.4 → 15.5.6 (patch) (#19194)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ eslint-config-next (15.5.4 → 15.5.6) Sorry, we couldn't find anything useful about this release. #### ✳️ next (15.5.4 → 15.5.6) · [Repo](https://github.com/vercel/next.js) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/vercel/next.js/releases/tag/v15.5.6">15.5.6</a></h4> <blockquote><div class="markdown-alert markdown-alert-note" dir="auto"> <p class="markdown-alert-title" dir="auto"><svg class="octicon octicon-info mr-2" viewbox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M0 8a8 8 0 1 1 16 0A8 8 0 0 1 0 8Zm8-6.5a6.5 6.5 0 1 0 0 13 6.5 6.5 0 0 0 0-13ZM6.5 7.75A.75.75 0 0 1 7.25 7h1a.75.75 0 0 1 .75.75v2.75h.25a.75.75 0 0 1 0 1.5h-2a.75.75 0 0 1 0-1.5h.25v-2h-.25a.75.75 0 0 1-.75-.75ZM8 6a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path></svg>Note</p> <p dir="auto">This release is backporting bug fixes. It does <strong>not</strong> include all pending features/changes on canary.</p> </div> <h3 dir="auto">Core Changes</h3> <ul dir="auto"> <li>Turbopack: don't define process.cwd() in node_modules <a href="https://bounce.depfu.com/github.com/vercel/next.js/pull/83452">#83452</a> </li> </ul> <h3 dir="auto">Credits</h3> <p dir="auto">Huge thanks to <a href="https://bounce.depfu.com/github.com/mischnic">@mischnic</a> for helping!</p></blockquote> <h4><a href="https://github.com/vercel/next.js/releases/tag/v15.5.5">15.5.5</a></h4> <blockquote><div class="markdown-alert markdown-alert-note" dir="auto"> <p class="markdown-alert-title" dir="auto"><svg class="octicon octicon-info mr-2" viewbox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M0 8a8 8 0 1 1 16 0A8 8 0 0 1 0 8Zm8-6.5a6.5 6.5 0 1 0 0 13 6.5 6.5 0 0 0 0-13ZM6.5 7.75A.75.75 0 0 1 7.25 7h1a.75.75 0 0 1 .75.75v2.75h.25a.75.75 0 0 1 0 1.5h-2a.75.75 0 0 1 0-1.5h.25v-2h-.25a.75.75 0 0 1-.75-.75ZM8 6a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path></svg>Note</p> <p dir="auto">This release is backporting bug fixes. It does <strong>not</strong> include all pending features/changes on canary.</p> </div> <h3 dir="auto">Core Changes</h3> <ul dir="auto"> <li>Split code-frame into separate compiled package (<a href="https://bounce.depfu.com/github.com/vercel/next.js/pull/84238">#84238</a>)</li> <li>Add deprecation warning to Runtime config (<a href="https://bounce.depfu.com/github.com/vercel/next.js/pull/84650">#84650</a>)</li> <li>fix: unstable_cache should perform blocking revalidation during ISR revalidation (<a href="https://bounce.depfu.com/github.com/vercel/next.js/pull/84716">#84716</a>)</li> <li>feat: <code class="notranslate">experimental.middlewareClientMaxBodySize</code> body cloning limit (<a href="https://bounce.depfu.com/github.com/vercel/next.js/pull/84722">#84722</a>)</li> <li>fix: missing next/link types with typedRoutes (<a href="https://bounce.depfu.com/github.com/vercel/next.js/pull/84779">#84779</a>)</li> </ul> <h3 dir="auto">Misc Changes</h3> <ul dir="auto"> <li>docs: early October improvements and fixes (<a href="https://bounce.depfu.com/github.com/vercel/next.js/pull/84334">#84334</a>)</li> </ul> <h3 dir="auto">Credits</h3> <p dir="auto">Huge thanks to <a href="https://bounce.depfu.com/github.com/devjiwonchoi">@devjiwonchoi</a>, <a href="https://bounce.depfu.com/github.com/ztanner">@ztanner</a>, and <a href="https://bounce.depfu.com/github.com/icyJoseph">@icyJoseph</a> for helping!</p></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/next/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href=" |
||
Robin Malfait
|
2530934a4f
|
update changelog | ||
|
Robin Malfait
|
cbbbe84475
|
Release 4.1.16 (#19185) v4.1.16 | ||
|
Robin Malfait
|
601d6719f8
|
Fix incorrect colors used in pseudo-element (#19184)
This PR essentially reverts https://github.com/tailwindlabs/tailwindcss/pull/19069 We added the nested `&` inside the `@supports` query when we create fallbacks for color-mix so that devtools (Safari) doesn't freak out. This works in most cases, however, if you have a parent pseudo element like `::before`, then the browser will not allow the nested `&` resulting in invalid CSS. This PR means that we go back to the broken devtools experience in Safari, but at least the CSS is valid and works as expected. Fixes: #19183 |
||
Jordan Pittman
|
a41add9fab
|
Improve canonicalization for & > :pseudo and & :pseudo arbitrary variants (#19178)
This improves canonicalization of arbitrary variants that use pseudo classes a bit. Before this we would see `[&_:first-child]:flex` and leave it be when it can instead be written as `**:first:flex`. Likewise, for pseudo classes that don't have a variant, we can still simplify things a bit as `[&_:--custom]` can be written `**:[:--custom]`. |
||
|
Jordan Pittman
|
0113b88fbd
|
Fix canonicalization of arbitrary variants with attribute selectors (#19176)
Fixes https://github.com/tailwindlabs/tailwindcss-intellisense/issues/1481 We were detecting when we needed to apply the `*` and `**` variants and even detecting attribute selectors. However we only cleaned up the attribute selectors when they were `data-*` or `aria-*` attributes. This resulted in a "loop" of sorts because we'd: - See something like `[&_>_[foo]]:flex` - Notice that it needs a `*` variant - Add the `*` variant, giving `*:[&_>[foo]]:flex` - But fail to cleanup the remainder of the variant This then meant that we'd see the `*:[&_>[foo]]:flex` the next time we checked, notice that it still needed a `*` variant, and repeat… This PR fixes this case to clean up the selector. |
||
|
Jordan Pittman
|
29687e0183
|
Discard candidates with an empty data type (#19172)
Fixes https://github.com/tailwindlabs/tailwindcss-intellisense/issues/1479 Maybe should close https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1480 — perhaps we can find a workaround there for older versions? We're building up a class name in code to validate if something is a valid variant: `{variant}:[color:red]` if `{variant}` got replaced with `bg-[` then we'd produce `bg-[:[color:red]` and this parsed as a valid candidate: ``` bg-[:[color:red] ^^ root: `bg` ^ data type: `` (empty string) — this should be invalid ^^^^^^^^^^ value: `[color:red` ``` The value isn't valid _but_ the syntax for arbitrary values is pretty lax in core. Oxide already won't pick something like this up though so no problem there. Only a problem for something like IntelliSense or clients using the compile() API directly. |
||
|
Robin Malfait
|
56e7f3b2c2
|
Improve memory usage during canonicalization (#19171)
This PR drastically improves the memory usage when performing canonicalization if you swap out the underlying DesignSystem often. This will be most noticeable in Intellisense. The big issue we had is that we used module scoped Map objects where we cache data based on the DesignSystem. If you then create new design systems (often), then the cache would just keep growing and growing. This PR solves that by essentially storing all the caches on the Design System itself. This way, when you throw away a Design System, all the caches go with it. Another approach would've been to use a WeakMap, but then we would have to make sure that no strong references to the DesignSystem exist anywhere else, otherwise we would still have the same memory issues. Note: make sure to go commit by commit and use `?w=1` to ignore whitespace changes. ## Test plan 1. All existing tests pass Not super sure how to test this as part of the test suite without making it slow But I also don't think that's super necessary either. Here is an experiment I did where I introduce 5 design systems: <img width="1326" height="274" alt="image" src="https://github.com/user-attachments/assets/817025e3-0f5b-44be-949b-54ed08f5b3fb" /> On the current `main` branch, this looks like: <img width="619" height="69" alt="image" src="https://github.com/user-attachments/assets/588ae99b-c978-4c01-bfd1-5cc0725723a8" /> In this PR, the memory usage looks like: <img width="512" height="56" alt="image" src="https://github.com/user-attachments/assets/0052ad21-7b99-4edf-8a14-8ccef52362db" /> The memory usage is stable, but to actually prove that we can still track multiple design systems, let's track them all in a `Set` so garbage collection cannot get rid of the unused design system objects: <img width="847" height="230" alt="image" src="https://github.com/user-attachments/assets/5f044927-3d53-4c15-8145-78eb2b4d6d54" /> Now we're sort of back to the current situation on `main`: <img width="507" height="53" alt="image" src="https://github.com/user-attachments/assets/868c0238-8646-41ce-8151-e0ef6dd17d64" /> |
||
|
Jordan Pittman
|
3a4ab8201b
|
Stop suggesting legacy utilities (#19169)
It was already supposed to work this way — and it appeared via the tests that it did — but the tests weren't loading the design system normally so when we split the legacy utilities into a separate file it stopped testing this properly. The setup here is a bit iffy but the gist is: - We allow static utilities to be suggested by default - A static utility can *opt out* of suggestions by explicitly registering themselves to return none. |
||
|
Robin Malfait
|
7537e34fd1
|
Ignore --tw- variables during internal signature computation (#19156)
This PR improves some of the signature computation logic. Right now,
when you want to convert `[font-weight:400]` to `font-normal` it's not
going to work because the signatures don't like up:
```css
/* [font-weight:400] */
.x {
font-weight: 400;
}
/* font-normal */
.x {
--tw-font-weight: 400;
font-weight: 400;
}
```
So this PR essentially ignores `--tw-{property}` _if_ the `{property}`
exists with the exact same value.
The main reason we have this, is to make composition of utilities
easier.
As with any of these upgrades, they are the expected behavior in most
cases, but there could always be a case where you don't want this, but
that's why the upgrade tool requires you to review each change before
applying it. Intellisense will recommend the simplified class, but it's
up to you to decide if you want to apply it or not.
There is a known edge case for `leading-{num}`, because the property is
`line-height` and the CSS variable is `--tw-leading`. Right now we map
`--tw-leading` to `line-height` but we can also update the leading
classes to use `--tw-line-height` instead but that feels like a bigger
breaking change _if_ people rely on these internal CSS variables...
|
||
|
Robin Malfait
|
66c18ca8a4
|
Collapse multiple utilities (#19147)
Some commits look like a lot of changes, but they just move things
around, so best to use `?w=1` when viewing commit by commit.
This PR adds a new feature to the `designSystem.canonicalizeCandidates`
to collapse multiple utilities to fewer utilities. To make this
possible, we also have to convert some logical properties to physical
properties (controllable via an option).
```ts
ds.canonicalizeCandidates(['w-4', 'h-4'], {
collapse: true // Default `true`
logicalToPhysical: true // Default `true`
}) // → ['size-4']
```
We can already compute the signature of each utility, where if two
utilities have the same signature they are considered the same.
However it's kind of impossible to generate all combinations of all
utilities ever to figure out if there is a potential collapse possible.
Even if we just focus on the incoming list of candidates, there could
still be a lot of classes. So instead we have to be a bit more clever.
First, we group candidates together by the used variants and if the
important `!` flag was used. We can improve this in the future, but for
now we won't even try to combine `hover:w-4 h-4`.
Next, for each candidate, we figure out which property and value it
uses. We can build up a lookup table for this. We already did this
process for all utilities in the system as well.
The lookup table for `w-4 h-4 p-4` might look something like this.
```json
{
"width": {
"16px": ["w-4", "size-4"],
},
"height": {
"16px": ["h-4", "size-4"],
},
"padding": {
"16px": ["p-4"],
}
}
```
Next, we can build groups of candidates where an intersection exists in
the lookup table. In the example above, we can see that `w-4` and `h-4`
both map to `size-4` for the value `16px`. So we can group these two
candidates. The `p-4`d doesn't intersect with anything else, so it
remains alone. This also means that we only have to generate
combinations for two candidates (2^2 = 4) instead of three (2^3 = 8). In
practice, your class list might have many classes, so keeping this
number low is important.
When we generate combinations, we will generate the most amount of
candidates first so we have the largest collapse possible. We also stop
when we reach <= 1 combinations because we need at least two candidates
to collapse.
Since this uses the internal design system, if you have custom
`@utility`s, this will work as expected.
```css
@utility example {
@apply border rounded p-4;
}
```
If you then use:
```html
<div class="border m-0 rounded p-4"></div>
```
Then we can collapse this to:
```html
<div class="example m-0"></div>
```
But even if we used:
```html
<div class="border m-0 rounded pt-4 pb-4 px-4"></div>
```
It would still collapse to:
```html
<div class="example m-0"></div>
```
...because the `pt-4` and `pb-4` can collapse to `py-4`, and `py-4` and
`px-4` can collapse to `p-4`.
This is also where that logical to physical conversion comes into play,
because while `pt-4` and `pb-4` set the physical `padding-top` and
`padding-bottom` properties. The `py-4` utility sets the logical
`padding-block` property. So we internally transform `padding-block` to
the `padding-top` and `padding-bottom` physical properties. The funny
thing is that this logical to physical conversion actually means that we
will convert `pt-4` and `pb-4` from _physical_ to _logical_ properties,
because we converted to `py-4`...
In _most_ cases it's fine, and even preferred to use `py-1` over `pt-1
pb-1`, but in case it's not, then you can disable the
`logicalToPhysical` option.
## Test plan
Added some dedicated tests for this new functionality.
|
||
|
Jordan Pittman
|
6c4081421e
|
Incorporate changes from latest ignore crate (#19148)
This updates our internal fork of the `ignore` crate to incorporate changes from the latest release [v0.4.24](https://github.com/BurntSushi/ripgrep/compare/ignore-0.4.23...ignore-0.4.24). Aside: We should look into opening issues about the changes we had to make to see if they could be addressed in the crate itself so we can get rid of our fork. |
||
|
depfu[bot]
|
a6a7e4cbaf
|
Update jiti 2.6.0 → 2.6.1 (patch) (#19160)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ jiti (2.6.0 → 2.6.1) · [Repo](https://github.com/unjs/jiti) · [Changelog](https://github.com/unjs/jiti/blob/main/CHANGELOG.md) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/unjs/jiti/releases/tag/v2.6.1">2.6.1</a></h4> <blockquote><p dir="auto"><a href="https://bounce.depfu.com/github.com/unjs/jiti/compare/v2.6.0...v2.6.1">compare changes</a></p> <h3 dir="auto">🩹 Fixes</h3> <ul dir="auto"> <li> <strong>interop:</strong> Only passthrough default if it is not a promise (<a href="https://bounce.depfu.com/github.com/unjs/jiti/pull/408">#408</a>)</li> </ul> <h3 dir="auto">📦 Build</h3> <ul dir="auto"> <li>Revert to <code class="notranslate">terser-webpack-plugin</code> (<a href="https://bounce.depfu.com/github.com/unjs/jiti/pull/407">#407</a>)</li> </ul> <h3 dir="auto">❤️ Contributors</h3> <ul dir="auto"> <li>Kricsleo (<a href="https://bounce.depfu.com/github.com/kricsleo">@kricsleo</a>)</li> </ul></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/jiti/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href=" |
||
|
Robin Malfait
|
b2e2435ccb
|
Release 4.1.15 (#19159) v4.1.15 | ||
|
Robin Malfait
|
3b636b74d7
|
Mark break-words as deprecated, and upgrade to wrap-break-word (#19157)
This PR marks `break-words` as deprecated (such that intellisense doesn't suggest it anymore). Updates the upgrade tooling to prefer `wrap-break-word` instead. Note: `break-words` will still work as expected. ## Test plan 1. `break-words` still generates the correct CSS. 2. Intellisense doesn't suggest `break-words` anymore. 3. Upgrade tooling suggests `wrap-break-word` instead of `break-words`. |
||
|
depfu[bot]
|
fb0f432e48
|
Update @types/bun 1.2.22 → 1.3.0 (minor) (#19145) | ||
|
Philipp Spiess
|
afe3de3bd6
|
Revert agentic issue-triage workflow (#19155)
Reverts #19057 Unfortunately wasn't able to get this to work since the permissions will always cause it to not be triggered when someone outside our GitHub orgs contributes. |
||
|
depfu[bot]
|
fee19b2d4e
|
Update bun 1.2.22 → 1.3.0 (minor) (#19144) | ||
|
Philipp Spiess
|
70f27d50a6
|
Remove Oxide postinstall script (#19149)
This PR effectively reverts #17929. The bug in npm that required it was fixed a couple of months ago and with recent changes to pnpm that requires manually approving all postinstall scripts, this is creating some unnecessary noise. |
||
|
Jordan Pittman
|
48c274d83e
|
Update Lightning CSS to 1.30.2 (#19143) | ||
|
depfu[bot]
|
e25c1f0594
|
Update eslint 9.36.0 → 9.37.0 (minor) (#19142)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ eslint (9.36.0 → 9.37.0) · [Repo](https://github.com/eslint/eslint) · [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/eslint/eslint/releases/tag/v9.37.0">9.37.0</a></h4> <blockquote><h2 dir="auto">Features</h2> <ul dir="auto"> <li> <a href=" |
||
|
depfu[bot]
|
71e1931044
|
Update @napi-rs/wasm-runtime 1.0.5 → 1.0.7 (patch) (#19140)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @napi-rs/wasm-runtime (1.0.5 → 1.0.7) · [Repo](https://github.com/napi-rs/napi-rs) Sorry, we couldn't find anything useful about this release. ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> |
||
Benoît Rouleau
|
89cbfc7b2d
|
Add optimize option to @tailwindcss/vite plugin (#19131)
Adds an `optimize` option to the Vite plugin that matches the API and
behavior of the PostCSS plugin.
Supports three formats:
- `optimize: false` - disable optimization
- `optimize: true` - enable optimization with minification
- `optimize: { minify: false }` - enable optimization without
minification
🤖 Generated with [Claude Code](https://claude.ai/code)
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jordan Pittman <jordan@cryptica.me>
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
|
||
|
Robin Malfait
|
acb27ef9e9
|
Generalize the walk implementation (#19126)
This PR generalizes the `walk` implementations we have. What's important
here is that we currently have multiple `walk` implementations, one for
the AST, one for the `SelectorParser`, one for the `ValueParser`.
Sometimes, we also need to go up the tree in a depth-first manner. For
that, we have `walkDepth` implementations.
The funny thing is, all these implementations are very very similar,
even the kinds of trees are very similar. They are just objects with
`nodes: []` as children.
So this PR introduces a generic `walk` function that can work on all of
these trees.
There are also some situations where you need to go down and back up the
tree. For this reason, we added an `enter` and `exit` phase:
```ts
walk(ast, {
enter(node, ctx) {},
exit(node, ctx) {},
})
```
This means that you don't need to `walk(ast)` and later `walkDepth(ast)`
in case you wanted to do something _after_ visiting all nodes.
The API of these walk functions also slightly changed to fix some
problems we've had before. One is the `replaceWith` function. You could
technically call it multiple times, but that doesn't make sense so
instead you always have to return an explicit `WalkAction`. The
possibilities are:
```ts
// The ones we already had
WalkAction.Continue // Continue walking as normal, the default behavior
WalkAction.Skip // Skip walking the `nodes` of the current node
WalkAction.Stop // Stop the entire walk
// The new ones
WalkAction.Replace(newNode) // Replace the current node, and continue walking the new node(s)
WalkAction.ReplaceSkip(newNode) // Replace the current node, but don't walk the new node(s)
WalkAction.ReplaceStop(newNode) // Replace the current node, but stop the entire walk
```
To make sure that we can walk in both directions, and to make sure we
have proper control over when to walk which nodes, the `walk` function
is implemented in an iterative manner using a stack instead of
recursion.
This also means that a `WalkAction.Stop` or `WalkAction.ReplaceStop`
will immediately stop the walk, without unwinding the entire call stack.
Some notes:
- The CSS AST does have `context` nodes, for this we can build up the
context lazily when we need it. I added a `cssContext(ctx)` that gives
you an enhanced context including the `context` object that you can read
information from.
- The second argument of the `walk` function can still be a normal
function, which is equivalent to `{ enter: fn }`.
Let's also take a look at some numbers. With this new implementation,
each `walk` is roughly ~1.3-1.5x faster than before. If you look at the
memory usage (especially in Bun) we go from `~2.2GB` peak memory usage,
to `~300mb` peak memory usage.
Some benchmarks on small and big trees (M1 Max):
<img width="2062" height="1438" alt="image"
src="https://github.com/user-attachments/assets/5ec8c22a-9de8-4e08-869a-18c0d30eb7e8"
/>
<img width="2062" height="1246" alt="image"
src="https://github.com/user-attachments/assets/e89d4b8e-29ca-4aee-8fd2-b7c043d3bbf4"
/>
We also ran some benchmarks on @thecrypticace's M3 Max:
<img width="1598" height="1452" alt="image"
src="https://github.com/user-attachments/assets/3b06b6fe-2497-4f24-a428-1a0e2af3896a"
/>
In node the memory difference isn't that big, but the performance itself
is still better:
<img width="2034" height="1586" alt="image"
src="https://github.com/user-attachments/assets/ef28ae14-b53e-4912-9621-531f3b02898f"
/>
In summary:
1. Single `walk` implementation for multiple use cases
2. Support for `enter` and `exit` phases
3. New `WalkAction` possibilities for better control
4. Overall better performance
5. ... and lower memory usage
## Test plan
1. All tests still pass (but had to adjust some of the APIs if `walk`
was used inside tests).
2. Added new tests for the `walk` implementation
3. Ran local benchmarks to verify the performance improvements
|
||
|
depfu[bot]
|
fc63ce7fbc
|
Update @vitejs/plugin-react 5.0.3 → 5.0.4 (patch) (#19129)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @vitejs/plugin-react (5.0.3 → 5.0.4) · [Repo](https://github.com/vitejs/vite-plugin-react) · [Changelog](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/CHANGELOG.md) <details> <summary>Release Notes</summary> <h4>5.0.4 (from changelog)</h4> <blockquote><h3 dir="auto">Perf: use native refresh wrapper plugin in rolldown-vite (<a href="https://bounce.depfu.com/github.com/vitejs/vite-plugin-react/pull/881">#881</a>)</h3></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/@vitejs%2Fplugin-react/feedback">Please let us know.</a></em></p> </details> ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> |
||
|
Robin Malfait
|
de6b54c307
|
Fix parsing issue when \t is used in at-rules (#19130)
This PR fixes an issue where an at-rule that used `@name\tparams` didn't properly parse because we didn't properly handle `\t`. ## Test plan 1. Added failing tests 2. Made them pass Fixes: #19127 |
||
|
Robin Malfait
|
22858ac4ae
|
Make TypeScript a bit more happy (#19124)
While working on another PR, I noticed that some files had missing properties and made TypeScript unhappy. Let's make TypeScript happy again... |
||
|
depfu[bot]
|
c7f6303070 | Update semver to version 7.7.3 | ||
|
depfu[bot]
|
28c72314fc
|
Update @types/react 19.1.13 → 19.2.2 (minor) (#19116)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @types/react (19.1.13 → 19.2.2) · [Repo](https://github.com/DefinitelyTyped/DefinitelyTyped) Sorry, we couldn't find anything useful about this release. ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> |
||
|
Jordan Pittman
|
f945c3d29f
|
Don’t index into strings with the theme(…) function (#19111)
Indexing into a string is only ever going to produce a single character and is almost guaranteed to be a mistake. The legacy keypath notation is meant to traverse objects and arrays — not strings. Fixes #19104 |
||
|
Jordan Pittman
|
2cba8319ce
|
Clone AST nodes used in staticValues (#19110)
These were getting mutated but they were shared instead of being re-created for new candidates. Cloning the nodes fixes this so mutation of the AST nodes doesn’t stick around. Fixes #19108 |
||
|
depfu[bot]
|
249bed0916
|
Update @napi-rs/cli 3.2.0 → 3.3.0 (minor) (#19102)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @napi-rs/cli (3.2.0 → 3.3.0) · [Repo](https://github.com/napi-rs/napi-rs) Sorry, we couldn't find anything useful about this release. ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Jordan Pittman <jordan@cryptica.me> |
||
|
Robin Malfait
|
c67c0c54cf
|
Canonicalize dimensions (#19101) | ||
|
depfu[bot]
|
496a1e9362
|
Update @types/react-dom 19.1.9 → 19.2.1 (minor) (#19088)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @types/react-dom (19.1.9 → 19.2.1) · [Repo](https://github.com/DefinitelyTyped/DefinitelyTyped) Sorry, we couldn't find anything useful about this release. ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Jordan Pittman <jordan@cryptica.me> |
||
|
depfu[bot]
|
53a8d3bc90
|
Update all of react 19.1.1 → 19.2.0 (minor) (#19087)
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ react (19.1.1 → 19.2.0) · [Repo](https://github.com/facebook/react) · [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/facebook/react/releases/tag/v19.2.0">19.2.0</a></h4> <blockquote><p dir="auto">Below is a list of all new features, APIs, and bug fixes.</p> <p dir="auto">Read the <a href="https://react.dev/blog/2025/10/01/react-19-2">React 19.2 release post</a> for more information.</p> <h2 dir="auto">New React Features</h2> <ul dir="auto"> <li> <a href="https://react.dev/reference/react/Activity"><code class="notranslate"><Activity></code></a>: A new API to hide and restore the UI and internal state of its children.</li> <li> <a href="https://react.dev/reference/react/useEffectEvent"><code class="notranslate">useEffectEvent</code></a> is a React Hook that lets you extract non-reactive logic into an <a href="https://react.dev/learn/separating-events-from-effects#declaring-an-effect-event">Effect Event</a>.</li> <li> <a href="https://react.dev/reference/react/cacheSignal"><code class="notranslate">cacheSignal</code></a> (for RSCs) lets your know when the <code class="notranslate">cache()</code> lifetime is over.</li> <li> <a href="https://react.dev/reference/developer-tooling/react-performance-tracks">React Performance tracks</a> appear on the Performance panel’s timeline in your browser developer tools</li> </ul> <h2 dir="auto">New React DOM Features</h2> <ul dir="auto"> <li>Added resume APIs for partial pre-rendering with Web Streams: <ul dir="auto"> <li> <a href="https://react.dev/reference/react-dom/server/resume"><code class="notranslate">resume</code></a>: to resume a prerender to a stream.</li> <li> <a href="https://react.dev/reference/react-dom/static/resumeAndPrerender"><code class="notranslate">resumeAndPrerender</code></a>: to resume a prerender to HTML.</li> </ul> </li> <li>Added resume APIs for partial pre-rendering with Node Streams: <ul dir="auto"> <li> <a href="https://react.dev/reference/react-dom/server/resumeToPipeableStream"><code class="notranslate">resumeToPipeableStream</code></a>: to resume a prerender to a stream.</li> <li> <a href="https://react.dev/reference/react-dom/static/resumeAndPrerenderToNodeStream"><code class="notranslate">resumeAndPrerenderToNodeStream</code></a>: to resume a prerender to HTML.</li> </ul> </li> <li>Updated <a href="https://react.dev/reference/react-dom/static/prerender"><code class="notranslate">prerender</code></a> APIs to return a <code class="notranslate">postponed</code> state that can be passed to the <code class="notranslate">resume</code> APIs.</li> </ul> <h2 dir="auto">Notable changes</h2> <ul dir="auto"> <li>React DOM now batches suspense boundary reveals, matching the behavior of client side rendering. This change is especially noticeable when animating the reveal of Suspense boundaries e.g. with the upcoming <code class="notranslate"><ViewTransition></code> Component. React will batch as much reveals as possible before the first paint while trying to hit popular first-contentful paint metrics.</li> <li>Add Node Web Streams (<code class="notranslate">prerender</code>, <code class="notranslate">renderToReadableStream</code>) to server-side-rendering APIs for Node.js</li> <li>Use underscore instead of <code class="notranslate">:</code> IDs generated by useId</li> </ul> <h2 dir="auto">All Changes</h2> <h3 dir="auto">React</h3> <ul dir="auto"> <li> <code class="notranslate"><Activity /></code> was developed over many years, starting before <code class="notranslate">ClassComponent.setState</code> (<a href="https://bounce.depfu.com/github.com/acdlite">@acdlite</a> <a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> and many others)</li> <li>Stringify context as "SomeContext" instead of "SomeContext.Provider" (<a href="https://bounce.depfu.com/github.com/kassens">@kassens</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33507">#33507</a>)</li> <li>Include stack of cause of React instrumentation errors with <code class="notranslate">%o</code> placeholder (<a href="https://bounce.depfu.com/github.com/eps1lon">@eps1lon</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34198">#34198</a>)</li> <li>Fix infinite <code class="notranslate">useDeferredValue</code> loop in popstate event (<a href="https://bounce.depfu.com/github.com/acdlite">@acdlite</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32821">#32821</a>)</li> <li>Fix a bug when an initial value was passed to <code class="notranslate">useDeferredValue</code> (<a href="https://bounce.depfu.com/github.com/acdlite">@acdlite</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34376">#34376</a>)</li> <li>Fix a crash when submitting forms with Client Actions (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33055">#33055</a>)</li> <li>Hide/unhide the content of dehydrated suspense boundaries if they resuspend (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32900">#32900</a>)</li> <li>Avoid stack overflow on wide trees during Hot Reload (<a href="https://bounce.depfu.com/github.com/sophiebits">@sophiebits</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34145">#34145</a>)</li> <li>Improve Owner and Component stacks in various places (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a>, <a href="https://bounce.depfu.com/github.com/eps1lon">@eps1lon</a>: <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33629">#33629</a>, <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33724">#33724</a>, <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32735">#32735</a>, <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33723">#33723</a>)</li> <li>Add <code class="notranslate">cacheSignal</code> (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33557">#33557</a>)</li> </ul> <h3 dir="auto">React DOM</h3> <ul dir="auto"> <li>Block on Suspensey Fonts during reveal of server-side-rendered content (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33342">#33342</a>)</li> <li>Use underscore instead of <code class="notranslate">:</code> for IDs generated by <code class="notranslate">useId</code> (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a>, <a href="https://bounce.depfu.com/github.com/eps1lon">@eps1lon</a>: <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32001">#32001</a>, <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33342">#33342</a><a href="https://bounce.depfu.com/github.com/facebook/react/pull/33099">#33099</a>, <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33422">#33422</a>)</li> <li>Stop warning when ARIA 1.3 attributes are used (<a href="https://bounce.depfu.com/github.com/Abdul-Omira">@Abdul-Omira</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34264">#34264</a>)</li> <li>Allow <code class="notranslate">nonce</code> to be used on hoistable styles (<a href="https://bounce.depfu.com/github.com/Andarist">@Andarist</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32461">#32461</a>)</li> <li>Warn for using a React owned node as a Container if it also has text content (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32774">#32774</a>)</li> <li>s/HTML/text for for error messages if text hydration mismatches (<a href="https://bounce.depfu.com/github.com/rickhanlonii">@rickhanlonii</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32763">#32763</a>)</li> <li>Fix a bug with <code class="notranslate">React.use</code> inside <code class="notranslate">React.lazy</code>-ed Component (<a href="https://bounce.depfu.com/github.com/hi-ogawa">@hi-ogawa</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33941">#33941</a>)</li> <li>Enable the <code class="notranslate">progressiveChunkSize</code> option for server-side-rendering APIs (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33027">#33027</a>)</li> <li>Fix a bug with deeply nested Suspense inside Suspense fallback when server-side-rendering (<a href="https://bounce.depfu.com/github.com/gnoff">@gnoff</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33467">#33467</a>)</li> <li>Avoid hanging when suspending after aborting while rendering (<a href="https://bounce.depfu.com/github.com/gnoff">@gnoff</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34192">#34192</a>)</li> <li>Add Node Web Streams to server-side-rendering APIs for Node.js (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33475">#33475</a>)</li> </ul> <h3 dir="auto">React Server Components</h3> <ul dir="auto"> <li>Preload <code class="notranslate"><img></code> and <code class="notranslate"><link></code> using hints before they're rendered (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34604">#34604</a>)</li> <li>Log error if production elements are rendered during development (<a href="https://bounce.depfu.com/github.com/eps1lon">@eps1lon</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34189">#34189</a>)</li> <li>Fix a bug when returning a Temporary reference (e.g. a Client Reference) from Server Functions (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34084">#34084</a>, <a href="https://bounce.depfu.com/github.com/denk0403">@denk0403</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33761">#33761</a>)</li> <li>Pass line/column to <code class="notranslate">filterStackFrame</code> (<a href="https://bounce.depfu.com/github.com/eps1lon">@eps1lon</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33707">#33707</a>)</li> <li>Support Async Modules in Turbopack Server References (<a href="https://bounce.depfu.com/github.com/lubieowoce">@lubieowoce</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34531">#34531</a>)</li> <li>Add support for .mjs file extension in Webpack (<a href="https://bounce.depfu.com/github.com/jennyscript">@jennyscript</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33028">#33028</a>)</li> <li>Fix a wrong missing key warning (<a href="https://bounce.depfu.com/github.com/unstubbable">@unstubbable</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34350">#34350</a>)</li> <li>Make console log resolve in predictable order (<a href="https://bounce.depfu.com/github.com/sebmarkbage">@sebmarkbage</a> <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33665">#33665</a>)</li> </ul> <h3 dir="auto">React Reconciler</h3> <ul dir="auto"> <li> <a href="https://bounce.depfu.com/github.com/facebook/react/blob/v19.2.0/packages/react-reconciler/src/ReactFiberReconciler.js#L255-L261">createContainer</a> and <a href="https://bounce.depfu.com/github.com/facebook/react/blob/v19.2.0/packages/react-reconciler/src/ReactFiberReconciler.js#L305-L312">createHydrationContainer</a> had their parameter order adjusted after <code class="notranslate">on*</code> handlers to account for upcoming experimental APIs</li> </ul> <h2 dir="auto">eslint-plugin-react-hooks@6.1.0</h2> <p dir="auto"><strong>Note:</strong> Version 6.0.0 was mistakenly released and immediately deprecated and untagged on npm. This is the first official 6.x major release and includes breaking changes.</p> <ul dir="auto"> <li> <strong>Breaking:</strong> Require Node.js 18 or newer. (<a href="https://bounce.depfu.com/github.com/michaelfaith">@michaelfaith</a> in <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32458">#32458</a>)</li> <li> <strong>Breaking:</strong> Flat config is now the default <code class="notranslate">recommended</code> preset. Legacy config moved to <code class="notranslate">recommended-legacy</code>. (<a href="https://bounce.depfu.com/github.com/michaelfaith">@michaelfaith</a> in <a href="https://bounce.depfu.com/github.com/facebook/react/pull/32457">#32457</a>)</li> <li> <strong>New Violations:</strong> Disallow calling <code class="notranslate">use</code> within try/catch blocks. (<a href="https://bounce.depfu.com/github.com/poteto">@poteto</a> in <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34040">#34040</a>)</li> <li> <strong>New Violations:</strong> Disallow calling <code class="notranslate">useEffectEvent</code> functions in arbitrary closures. (<a href="https://bounce.depfu.com/github.com/jbrown215">@jbrown215</a> in <a href="https://bounce.depfu.com/github.com/facebook/react/pull/33544">#33544</a>)</li> <li>Handle <code class="notranslate">React.useEffect</code> in addition to <code class="notranslate">useEffect</code> in rules-of-hooks. (<a href="https://bounce.depfu.com/github.com/Ayc0">@Ayc0</a> in <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34076">#34076</a>)</li> <li>Added <code class="notranslate">react-hooks</code> settings config option that to accept <code class="notranslate">additionalEffectHooks</code> that are used across exhaustive-deps and rules-of-hooks rules. (<a href="https://bounce.depfu.com/github.com/jbrown215">@jbrown215</a>) in <a href="https://bounce.depfu.com/github.com/facebook/react/pull/34497">#34497</a> </li> </ul></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/react/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href=" |
||
|
Robin Malfait
|
01d1e98259
|
Canonicalization constant folding and handling zeros (#19095)
The main goal of this PR was to support canonicalization of zero like values. We essentially want to canonicalize `-mt-0` as `mt-0`, but also `mt-[0px]`, `mt-[0rem]`, and other length-like units to just `mt-0`. To do this, we had to handle 2 things: 1. We introduced some more constant folding, including making `0px` and `0rem` fold to `0`. We only do this for length units. We also normalize `-0`, `+0`, `-0.0` and so on to `0`. 2. While pre-computing utilities in our lookup table, we make sure that we prefer `mt-0` over `-mt-0` if both result in the same signature. Moved some of the constant folding logic into its own function and added a bunch of separate tests for it. ## Test plan Added more unit tests where we normalize different zero-like values to `0`. Running the canonicalization logic: ```js designSystem.canonicalizeCandidates([ '-m-0', '-m-[-0px]', '-m-[-0rem]', '-m-[0px]', '-m-[0rem]', 'm-0', 'm-[-0px]', 'm-[-0rem]', 'm-[0px]', 'm-[0rem]', 'm-[calc(var(--spacing)*0)]', 'm-[--spacing(0)]', 'm-[--spacing(0.0)]', 'm-[+0]', 'm-[-0]', '-m-[-0]', '-m-[+0]', ]) // → ['m-0'] ``` --------- Co-authored-by: Jordan Pittman <jordan@cryptica.me> |
||
|
Robin Malfait
|
3aadba7cc1
|
Move modifier of not-*, has-*, and in-* variant to sub variant (#19100)
This PR fixes an issue where a compound variant with a modifier such as `not-group-hover/name:flex` would not generate anything because the `/name` modifier belongs to the `not` variant, and not the compounded `group-hover` variant. This PR is a **workaround** (and definitely not perfect) by special casing the `not`, `has`, and `in` variants such that their modifiers are moved internally to the sub variant as-if the `/name` existed on `group-hover`. We don't do it for other compound variants such as `group` and `peer` because then `group-peer-focus/name:underline` would result in a breaking change: ```diff - .group-peer-focus\\/name\\:flex:is(:where(.group\\/name):is(:where(.peer):focus ~ *) *) + .group-peer-focus\/name\:flex:is(:where(.group):is(:where(.peer\/name):focus ~ *) *) ``` In case the diff is not clear, the name has moved: <img width="1219" height="78" alt="image" src="https://github.com/user-attachments/assets/dce7bc95-9d93-452d-a275-b3891a05a1a4" /> This is also a limited workaround, because if you need multiple modifiers it won't work. I would've loved to special case this _inside_ the `not`, `has`, and `in` code that handles these variants, but we handle the variants in a depth-first way, so by the time you are handling the `not` variant, the sub variant was already handled... In a perfect world, you can use something like `not-group/name-hover` but then it becomes unambiguous because is `name` the name, is `name-hover`? ## Test plan Added a new test that wouldn't generate anything before this fix. Fixes: #15772 |
||
|
Robin Malfait
|
0c14df1a15
|
Fix resolving colors via theme(…) in compat mode with nested objects (#19097)
This PR fixes an issue when loading (nested) colors from a config file
and later referencing it via the `theme(…)` function in CSS.
Given a config like this:
```js
module.exports = {
theme: {
colors: {
foo: 'var(--foo-foo)',
'foo-bar': 'var(--foo-foo-bar)',
},
},
}
```
We internally map this into the design system. The issue here is that
the `foo` and `foo-bar` are overlapping and it behaves more like this:
```js
{
foo: {
DEFAULT: 'var(--foo-foo)',
bar: 'var(--foo-foo-bar)'
},
}
```
So while we can easily resolve `colors.foo-bar`, the `colors.foo` would
result in the object with a `DEFAULT` key. This PR solves that by using
the `DEFAULT` key if we end up with an object that has it.
If you end up resolving an object (`theme(colors)`) then the behavior is
unchanged.
## Test plan
1. Added a test based on the config in the issue (which failed before
this fix).
2. Also simplified the test case after identifying the problem (with the
`DEFAULT` key).
Fixes: #19091
|
||
|
Robin Malfait
|
561983d7e5
|
Suppress warnings when using :deep, :slotted and :global (#19094)
This PR ignores warnings related to `:deep`, `:slotted` and `:global` used by frameworks like Vue (see: https://vuejs.org/api/sfc-css-features#deep-selectors). ## Test plan Used a `:deep()` selector in a test project (Catalyst). ```diff diff --git a/templates/catalyst/src/tailwind.css b/templates/catalyst/src/tailwind.css index 79887e67..2acb749c 100644 --- a/templates/catalyst/src/tailwind.css +++ b/templates/catalyst/src/tailwind.css @@ -9,3 +9,7 @@ --font-sans: Inter, sans-serif; --font-sans--font-feature-settings: 'cv11'; } + +:deep(.foo) { + color: red; +} ``` Before: <img width="1625" height="372" alt="image" src="https://github.com/user-attachments/assets/4b948080-1aeb-41ba-8268-98828da21768" /> After: <img width="717" height="114" alt="image" src="https://github.com/user-attachments/assets/b8668da2-693e-4010-99fb-de3bc4a47bf9" /> Fixes: https://github.com/tailwindlabs/tailwindcss/pull/18918#issuecomment-3384928613 |
||
|
Robin Malfait
|
0c8d881f0e
|
Improve percentage canonicalization (#19072)
This PR improves the canonicalization of percentage values such that `[.1]`, `[.10]`, `[10%]` and `[10.0%]` are all treated as the same value. Right now we're only focusing on percentages. We can likely do this for all numbers, but I'm a little afraid of places where you can have multiple numbers separated by multiple dots (think SVGs). ## Test plan 1. Added more tests to cover the new cases. 2. Tested it in a local test project, where you can see the normalization in action. <img width="1383" height="117" alt="image" src="https://github.com/user-attachments/assets/03d99e3a-4404-437b-b458-58f7e8ce60da" /> |
||
|
Robin Malfait
|
efe084b7e7
|
Improve performance of cloning AST nodes (#19067)
This PR improves the performance of when we need to clone some AST
nodes. We have a few places where we clone `Candidate`, `Variant` and
CSS `AST` nodes.
Right now we use `structuredClone`, which works, but it is a generic
solution. However, we do know the exact structure of these AST nodes, so
we can write specialized clone functions that are much faster.
## Test plan
1. All the tests still pass with this change
2. The performance is better:
```
cloneCandidate - src/candidate.bench.ts > Candidate cloning
1.72x faster than cloneCandidate (spread)
74.03x faster than structuredClone
cloneAstNode() - src/ast.bench.ts > Cloning AST nodes
1.15x faster than cloneAstNode (with spread)
33.54x faster than structuredClone()
```
Ready for review, but should be merged after #19059
|
||
|
Robin Malfait
|
b77971f754
|
Introduce canonicalizeCandidates on the internal Design System (#19059)
This PR introduces a new `canonicalizeCandidates` function on the internal Design System. The big motivation to moving this to the core `tailwindcss` package is that we can use this in various places: - The Raycast extension - The VS Code extension / language server - 3rd party tools that use the Tailwind CSS design system APIs > This PR looks very big, but **I think it's best to go over the changes commit by commit**. Basically all of these steps already existed in the upgrade tool, but are now moved to our core `tailwindcss` package. Here is a list of all the changes: - Added a new `canonicalizeCandidates` function to the design system - Moved various migration steps to the core package. I inlined them in the same file and because of that I noticed a specific pattern (more on this later). - Moved `printCandidate` tests to the `tailwindcss` package - Setup tests for `canonicalizeCandidates` based on the existing tests in the upgrade tool. I noticed that all the migrations followed a specific pattern: 1. Parse the raw candidate into a `Candidate[]` AST 2. In a loop, try to migrate the `Candidate` to a new `Candidate` (this often handled both the `Candidate` and its `Variant[]`) 3. If something changed, print the new `Candidate` back to a string, and pass it to the next migration step. While this makes sense in isolation, we are doing a lot of repeated work by parsing, modifying, and printing the candidate multiple times. This let me to introduce the `big refactor` commit. This changes the steps to: 1. Up front, parse the raw candidate into a `Candidate[]` _once_. 2. Strip the variants and the important marker from the candidate. This means that each migration step only has to deal with the base `utility` and not care about the variants or the important marker. We can re-attach these afterwards. 3. Instead of a `rawCandidate: string`, each migration step receives an actual `Candidate` object (or a `Variant` object). 4. I also split up the migration steps for the `Candidate` and the `Variant[]`. All of this means that there is a lot less work that needs to be done. We can also cache results between migrations. So `[@media_print]:flex` and `[@media_print]:block` will result in `print:flex` and `print:block` respectively, but the `[@media_print]` part is only migrated once across both candidates. One migration step relied on the `postcss-selector-parser` package to parse selectors and attribute selectors. I didn't want to introduce a package just for this, so instead used our own `SelectorParser` in the migration and wrote a small `AttributeSelectorParser` that can parse the attribute selector into a little data structure we can work with instead. If we want, we can split this PR up into smaller pieces, but since the biggest chunk is moving existing code around, I think it's fairly doable to review as long as you go commit by commit. --- With this new API, we can turn: ``` [ 'bg-red-500', 'hover:bg-red-500', '[@media_print]:bg-red-500', 'hover:[@media_print]:bg-red-500', 'bg-red-500/100', 'hover:bg-red-500/100', '[@media_print]:bg-red-500/100', 'hover:[@media_print]:bg-red-500/100', 'bg-[var(--color-red-500)]', 'hover:bg-[var(--color-red-500)]', '[@media_print]:bg-[var(--color-red-500)]', 'hover:[@media_print]:bg-[var(--color-red-500)]', 'bg-[var(--color-red-500)]/100', 'hover:bg-[var(--color-red-500)]/100', '[@media_print]:bg-[var(--color-red-500)]/100', 'hover:[@media_print]:bg-[var(--color-red-500)]/100', 'bg-(--color-red-500)', 'hover:bg-(--color-red-500)', '[@media_print]:bg-(--color-red-500)', 'hover:[@media_print]:bg-(--color-red-500)', 'bg-(--color-red-500)/100', 'hover:bg-(--color-red-500)/100', '[@media_print]:bg-(--color-red-500)/100', 'hover:[@media_print]:bg-(--color-red-500)/100', 'bg-[color:var(--color-red-500)]', 'hover:bg-[color:var(--color-red-500)]', '[@media_print]:bg-[color:var(--color-red-500)]', 'hover:[@media_print]:bg-[color:var(--color-red-500)]', 'bg-[color:var(--color-red-500)]/100', 'hover:bg-[color:var(--color-red-500)]/100', '[@media_print]:bg-[color:var(--color-red-500)]/100', 'hover:[@media_print]:bg-[color:var(--color-red-500)]/100', 'bg-(color:--color-red-500)', 'hover:bg-(color:--color-red-500)', '[@media_print]:bg-(color:--color-red-500)', 'hover:[@media_print]:bg-(color:--color-red-500)', 'bg-(color:--color-red-500)/100', 'hover:bg-(color:--color-red-500)/100', '[@media_print]:bg-(color:--color-red-500)/100', 'hover:[@media_print]:bg-(color:--color-red-500)/100', '[background-color:var(--color-red-500)]', 'hover:[background-color:var(--color-red-500)]', '[@media_print]:[background-color:var(--color-red-500)]', 'hover:[@media_print]:[background-color:var(--color-red-500)]', '[background-color:var(--color-red-500)]/100', 'hover:[background-color:var(--color-red-500)]/100', '[@media_print]:[background-color:var(--color-red-500)]/100', 'hover:[@media_print]:[background-color:var(--color-red-500)]/100' ] ``` Into their canonicalized form: ``` [ 'bg-red-500', 'hover:bg-red-500', 'print:bg-red-500', 'hover:print:bg-red-500' ] ``` The list is also unique, so we won't end up with `bg-red-500 bg-red-500` twice. While the canonicalization itself is fairly fast, we still pay a **~1s** startup cost for some migrations (once, and cached for the entire lifetime of the design system). I would like to keep improving the performance and the kinds of migrations we do, but I think this is a good start. The cost we pay is for: 1. Generating a full list of all possible utilities based on the `getClassList` suggestions API. 2. Generating a full list of all possible variants. The canonicalization step for this list takes **~2.9ms** on my machine. Just for fun, if you use the `getClassList` API for intellisense that generates all the suggestions and their modifiers, you get a list of **263788** classes. If you canonicalize all of these, it takes **~500ms** in total. So roughly **~1.9μs** per candidate. This new API doesn't result in a performance difference for normal Tailwind CSS builds. The other potential concern is file size of the package. The generated `tailwindcss.tgz` file changed like this: ```diff - 684652 bytes (684.65 kB) + 749169 bytes (749.17 kB) ``` So the package increased by ~65 kB which I don't think is the end of the world, but it is important for the `@tailwindcss/browser` build which we don't want to grow unnecessarily. For this reason we remove some of the code for the design system conditionally such that you don't pay this cost in an environment where you will never need this API. The `@tailwindcss/browser` build looks like this: ```shell `dist/index.global.js 255.14 KB` (main) `dist/index.global.js 272.61 KB` (before this change) `dist/index.global.js 252.83 KB` (after this change, even smaller than on `main`) ``` |
||
|
Robin Malfait
|
73628f69f3
|
Fix Safari devtools issues because of nested @supports at-rules without normal rule (#19069)
This PR fixes a weird Safari rendering bug in the devtools. This seems
to be happening when using `@supports`, especially nested `@supports`
at-rules.
The issue is that our color-mix fallback generates declarations directly
in `@supports` at-rules which causes the weird rendering bug in Safari.
Adding this intermediate `&` rule seems to fix the issue.
This is a workaround for a browser bug, but the additional 3 characters
shouldn't be the end of the world.
## Test plan
1. Updated the tests with the new `& { }` intermediate rule
2. Other tests still pass as expected
| Before | After |
| --- | --- |
| <img width="450" height="549" alt="image"
src="https://github.com/user-attachments/assets/4b51fb93-8073-4414-8139-dec75e6bc086"
/> | <img width="448" height="548" alt="image"
src="https://github.com/user-attachments/assets/1016af67-c1eb-43dc-9554-158e7e2264c4"
/> |
Fixes: #19065
[ci-all]
|
||
|
Robin Malfait
|
49948d087e
|
Fix failing integration tests (#19068)
The vite/nuxt integration tests started failing because one of the internal dependencies (`nuxi`) was updated from `3.28.0` to `3.29.0` which includes a newer version of `undici` which in turn relies on `node:sqlite`. `node:sqlite` was added in a newer Node version, and we still use Node v20 in CI. This PR pins `nuxi` to `3.28.0` until we can upgrade our Node version in CI. [ci-all] |
||
|
Robin Malfait
|
86e4b8e636
|
run prettier |
