Merge pull request #2179 from serverless/pr-template

Improve PR template for clearer validation data
This commit is contained in:
Florian Motlik 2016-09-26 12:51:09 +02:00 committed by GitHub
commit d17801d39c

View File

@ -1,8 +1,7 @@
<!--
1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
2. Fill out the whole template so we have a good overview on the issue
3. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR
3. Please follow the template, otherwise we'll have to ask you to update it
2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR
3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged
-->
## What did you implement:
@ -23,8 +22,14 @@ If this is a nontrivial change please briefly describe your implementation so it
<!--
Add any applicable config, commands, screenshots or other resources
to make it easy for us to verify this works, e.g. an example serverless.yml
or AWS CLI commands to trigger something.
to make it easy for us to verify this works. The easier you make it for us
to review a PR, the faster we can review and merge it.
Examples:
* serverless.yml - Fully functioning to easily deploy changes
* Screenshots - Showing the difference between your output and the master
* AWS CLI commands - To list AWS resources and show that the correct config is in place
* Other - Anything else that comes to mind to help us evaluate
-->
@ -35,4 +40,7 @@ or AWS CLI commands to trigger something.
- [ ] Fix linting errors
- [ ] Make sure code coverage hasn't dropped
- [ ] Provide verification config/commands/resources
- [ ] Leave a comment that this is ready for review once you've finished the implementation
- [ ] Change ready for review message below
***Is this ready for review?:*** NO