From 77f3133bf4b33bdc263f423f58087e81dbbbaccb Mon Sep 17 00:00:00 2001 From: Florian Motlik Date: Wed, 21 Sep 2016 18:53:44 +0200 Subject: [PATCH 1/2] Improve PR template for clearer validation data --- .github/PULL_REQUEST_TEMPLATE.md | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 92171cc87..b4e0f09f7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,7 @@ ## What did you implement: @@ -23,8 +22,14 @@ If this is a nontrivial change please briefly describe your implementation so it @@ -35,4 +40,7 @@ or AWS CLI commands to trigger something. - [ ] Fix linting errors - [ ] Make sure code coverage hasn't dropped - [ ] Provide verification config/commands/resources -- [ ] Leave a comment that this is ready for review once you've finished the implementation +- [ ] Change ready for review message below + + +***Is this ready for review?:*** NO From a176b49a57eb92395c36cbcf607b1e0856eac128 Mon Sep 17 00:00:00 2001 From: Florian Motlik Date: Fri, 23 Sep 2016 21:47:50 +0200 Subject: [PATCH 2/2] Update PR Template with feedback from @pmuens --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b4e0f09f7..4c321d3fd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -26,10 +26,10 @@ to make it easy for us to verify this works. The easier you make it for us to review a PR, the faster we can review and merge it. Examples: -* Fully functioning serverless.yml to easily deploy changes -* Screenshot showing the difference between your output and the master -* AWS CLI commands to list AWS resources and show that the correct config is in place -* Anything else that comes to mind to help us evaluate +* serverless.yml - Fully functioning to easily deploy changes +* Screenshots - Showing the difference between your output and the master +* AWS CLI commands - To list AWS resources and show that the correct config is in place +* Other - Anything else that comes to mind to help us evaluate -->