archive-gh-me/react-map-gl
1
0
Fork 0
mirror of https://github.com/visgl/react-map-gl.git synced 2026-01-18 15:54:22 +00:00
Code Issues Projects Releases Wiki Activity

Force map rerender synchronously after props update (#720)

Browse Source
This commit is contained in:
Xiaoji Chen 2019-02-11 13:33:43 -08:00 committed by GitHub
parent 030c223654
commit bd85a56e48
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/mapbox/mapbox.js
View File

@ -211,13 +211,25 @@ export default class Mapbox {
// (e.g. until "componentDidUpdate")
resize() {
this._map.resize();
// map render will throw error if style is not loaded
if (this._map.isStyleLoaded()) {
this._map._render();
}
return this;
}
// Force redraw the map now. Typically resize() and jumpTo() is reflected in the next
// render cycle, which is managed by Mapbox's animation loop.
// This removes the synchronization issue caused by requestAnimationFrame.
redraw() {
const map = this._map;
// map render will throw error if style is not loaded
if (map.isStyleLoaded()) {
map._render();
// cancel the scheduled update
if (map._frame) {
map._frame.cancel();
map._frame = null;
}
}
}
// External apps can access map this way
getMap() {
return this._map;
@ -369,8 +381,12 @@ export default class Mapbox {
newProps = Object.assign({}, this.props, newProps);
checkPropTypes(newProps, 'Mapbox');
this._updateMapViewport(oldProps, newProps);
this._updateMapSize(oldProps, newProps);
const viewportChanged = this._updateMapViewport(oldProps, newProps);
const sizeChanged = this._updateMapSize(oldProps, newProps);
if (viewportChanged || sizeChanged) {
this.redraw();
}
this.props = newProps;
}
@ -383,6 +399,7 @@ export default class Mapbox {
this.height = newProps.height;
this.resize();
}
return sizeChanged;
}
_updateMapViewport(oldProps: any, newProps: Props) {
@ -405,6 +422,7 @@ export default class Mapbox {
this._map.transform.altitude = newViewState.altitude;
}
}
return viewportChanged;
}
_getViewState(props: Props) : ViewState {