archive-gh-me/react-map-gl
1
0
Fork 0
mirror of https://github.com/visgl/react-map-gl.git synced 2026-01-25 16:02:50 +00:00
Code Issues Projects Releases Wiki Activity

Deregister mapbox events listeners when destroy map (#723)

Browse Source
This commit is contained in:
Xintong Xia 2019-02-09 20:16:14 +01:00 committed by GitHub
parent 1e96af8fb4
commit 030c223654
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/mapbox/mapbox.js
View File

@ -224,6 +224,13 @@ export default class Mapbox {
}
// PRIVATE API
_fireLoadEvent = () => {
this.props.onLoad({
type: 'load',
target: this._map
});
};
_reuse(props: Props) {
this._map = Mapbox.savedMap;
// When reusing the saved map, we need to reparent the map(canvas) and other child nodes
@ -240,11 +247,6 @@ export default class Mapbox {
Mapbox.savedMap = null;
// Step3: update style and call onload again
const fireLoadEvent = () => props.onLoad({
type: 'load',
target: this._map
});
if (props.mapStyle) {
this._map.setStyle(props.mapStyle, {
diff: true
@ -253,9 +255,9 @@ export default class Mapbox {
// call onload event handler after style fully loaded when style needs update
if (this._map.isStyleLoaded()) {
fireLoadEvent();
this._fireLoadEvent();
} else {
this._map.once('styledata', fireLoadEvent);
this._map.once('styledata', this._fireLoadEvent);
}
}
@ -312,9 +314,16 @@ export default class Mapbox {
if (!Mapbox.savedMap) {
Mapbox.savedMap = this._map;
// deregister the mapbox event listeners
this._map.off('load', this.props.onLoad);
this._map.off('error', this.props.onError);
this._map.off('styledata', this._fireLoadEvent);
} else {
this._map.remove();
}
this._map = null;
}