Brian M. Carlson
492fbdbb65
Merge branch 'juneidysoo-master'
2019-12-18 13:17:49 -06:00
Brian M. Carlson
e20d0128fc
Merge branch 'master' of https://github.com/juneidysoo/node-pg-cursor into juneidysoo-master
2019-12-18 13:16:55 -06:00
Brian C
e34c6021ef
Merge pull request #32 from hetul/fix-closing-finished-connections
...
Fix closing a finished cursor without supplying a callback
2019-12-18 12:38:30 -06:00
Hetul Patel
124c89b173
fix lint issues
2019-12-13 15:30:40 -08:00
Brian M. Carlson
37906091e1
Bump version
2019-10-30 12:55:38 -05:00
Brian C
5055b3a244
Merge pull request #58 from brianc/bmc/add-test-and-deprecate-method
...
Add additional pool test & deprecate .end
2019-10-30 12:55:02 -05:00
Brian M. Carlson
cedce4bded
Fix lint & enable all tests
2019-10-30 12:52:06 -05:00
Brian M. Carlson
507c7eaca4
Merge branch 'master' into bmc/add-test-and-deprecate-method
2019-10-30 12:47:14 -05:00
Brian C
d0e67a93ff
Merge pull request #59 from brianc/bmc/fix-named-portal
...
Fix named portal not closing
2019-10-30 12:46:13 -05:00
Brian M. Carlson
bd86514c72
Add another test
2019-10-30 11:43:17 -05:00
Brian M. Carlson
389d5d8c14
Fix named portal being left open
...
When code was added to use a random named portal instead of the empty portal to support redshift we didn't update the close messages approprately. This could result in postgres keeping locks on tables for modification if streaming and table modification was both done within a transaction. This update fixes the issue by always issuing a close command on the named portal when query is finished.
fixes #56
2019-10-30 11:33:52 -05:00
Brian M. Carlson
d3aee3dfc8
Add additional pool test & deprecate .end
...
There are no tests covering cursor.end(). It's also a weird method to have on the cursor as it terminates the connection to postgres internally. I don't recall why I added this method in the first place but its not correct to close a connection to postgres by calling .end on a cursor...seems like a pretty big footgun. If you have a pooled client and you call `cursor.end` it'll close the client internally and likely confuse the pool. Plus it's just weird to be able to close a connection by calling .end on a query or cursor. So...I'm deprecating that method.
2019-10-28 11:45:20 -05:00
Brian C
ff09b3f21d
Merge branch 'master' into fix-closing-finished-connections
2019-10-25 18:19:19 -05:00
Brian C
6d47026083
Merge pull request #57 from brianc/bmc/lint-changes
...
Fix for pg@7.x
2019-10-25 18:17:44 -05:00
Brian M. Carlson
be0321299b
Update lint, fix for pg@7.x
2019-10-25 18:11:53 -05:00
Brian M. Carlson
4164686c4b
meh
2019-10-25 18:03:07 -05:00
Brian M. Carlson
414fac6a05
Apply prettier to code, change lint rules
2019-10-25 12:14:27 -05:00
Juneidy
b0f7958299
Fix hanging listener when error occured
2019-06-27 11:55:38 +08:00
Brian M. Carlson
1cdad4d8d2
Bump version. Drop support for pg.js
2019-01-08 08:53:58 -06:00
Brian M. Carlson
71dde045ea
Merge branch 'master' of github.com:brianc/node-pg-cursor
2019-01-08 08:52:25 -06:00
Brian C
67b880a4bd
Merge pull request #35 from jakobrun/master
...
return rowCount on insert
2019-01-08 08:52:20 -06:00
Brian M. Carlson
1200da5c74
Fix test
2019-01-08 08:52:05 -06:00
Brian C
0a1052516f
Merge pull request #44 from jafl/redshift-requires-portal-name
...
fix: AWS Redshift requires a portal name to honor fetchSize
2019-01-08 08:28:39 -06:00
Brian C
73506d36b9
Merge pull request #47 from pistor/remove-pg.js-support
...
Remove support for deprecated pg.js package
2019-01-08 08:27:07 -06:00
Mikkel Hoegh
6fc07b4a63
fix: remove support for deprecated pg.js package
...
BREAKING CHANGE: pg.js is long dead and no longer supported.
Use [pg](https://www.npmjs.com/package/pg ) instead.
2018-12-05 00:06:10 +01:00
John Lindal
37997fed76
fix formatting issues
2018-10-23 09:59:50 -07:00
John Lindal
19c68c753e
fix: AWS Redshift requires a portal name to honor fetchSize
2018-10-17 14:30:56 -07:00
Brian C
91bdbbd3d7
Merge pull request #40 from savvymas/patch-1
...
Add repo to package.json
2018-06-21 14:13:11 -07:00
Savannah Mastrangelo
7eabfbe0ba
Add repo to package.json
...
Without this pages like https://www.npmjs.com/package/pg-cursor don't link back correctly.
2018-06-20 12:29:41 -04:00
jakob
2398e992a8
return rowCount on insert
2018-01-01 18:43:18 +00:00
Hetul Patel
24e485e81e
Fix closing a finished cursor without supplying a callback
2017-10-03 18:13:40 -07:00
Brian C
c0f5518341
Update README.md
...
Add link to updated documentation
2017-08-08 11:24:06 -05:00
Brian M. Carlson
796d141386
Bump version
2017-08-06 11:28:37 -05:00
Brian C
b97a442f07
Merge pull request #30 from brianc/suport-query-config
...
Add support for rowMode & custom types
2017-08-06 11:28:22 -05:00
Brian M. Carlson
e0b2e41e57
Fix lint
2017-08-05 18:25:09 -05:00
Brian M. Carlson
4ff97f54bf
Add support for rowMode & custom types
2017-08-05 18:22:54 -05:00
Brian M. Carlson
5b4bb7b615
Bump version
2017-08-05 17:29:58 -05:00
Brian C
71f30faeda
Merge pull request #29 from brianc/no-sync-callbacks
...
Cleanup
2017-08-05 17:28:48 -05:00
Brian M. Carlson
bbefeb8670
Remove unused file
2017-08-05 17:25:13 -05:00
Brian M. Carlson
2ced8f1f2b
Integrate eslint
2017-08-05 17:24:49 -05:00
Brian M. Carlson
3675d2b041
Fix to support node@4 LTS
2017-08-05 17:17:24 -05:00
Brian Carlson
a720dc774b
Some cleanup
2017-08-05 16:59:20 -05:00
Brian M. Carlson
5a0af8cdd1
Bump version
2017-08-05 15:56:56 -05:00
Brian C
25d978e593
Merge pull request #28 from brianc/rickbergfalk-master
...
Do not send close after readyForQuery
2017-08-05 15:55:54 -05:00
Brian M. Carlson
620ddc0ded
Do not send close after readyForQuery
...
Close is used to release a named portal (which isn't used by pg-cursor) or when you're early-terminating a cursor on the unnamed portal. Sending 'close' on an connection which has already sent 'readyForQuery' results in the connection responding with a _second_ 'readyForQuery' which causes a lot of issues within node-postgres as 'readyForQuery' is the signal to indicate the client has gone back into the idle state.
2017-08-04 17:40:52 -05:00
Rick Bergfalk
6072bcea8e
Merge remote-tracking branch 'brianc/master'
2017-08-04 16:58:34 -04:00
Rick Bergfalk
9c7d2c853e
Test cursor with pg-pool
2017-08-04 16:58:32 -04:00
Brian M. Carlson
6e462ffae6
Bump version
2017-05-15 23:16:55 -05:00
Brian C
bbc2b416ed
Merge pull request #25 from sberan/cursor-result
...
Emit Query Events
2017-05-15 23:15:59 -05:00
Sam Beran
4427e31661
fix travis build env
2017-05-09 10:13:57 -05:00
