archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

Revert "Fixes #705 - Throw error when the root HTML element has a dynamic id …"

Browse Source
This commit is contained in:
Austin Kelleher 2017-06-01 16:12:09 -04:00 committed by GitHub
parent 4eb20477a2
commit a998535db7
5 changed files with 4 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/components/taglib/TransformHelper/handleRootNodes.js
View File

@ -199,16 +199,9 @@ module.exports = function handleRootNodes() {
hasLegacyExplicitBind = true;
} else {
if (node.hasAttribute('id')) {
let id = node.getAttributeValue('id');
if (id && id.type !== 'Literal') {
context.addError('Root HTML element should not have a dynamic `id` attribute. See: https://github.com/marko-js/marko/wiki/Error:-Dynamic-root-HTML-element-id-attribute');
return;
}
hasIdCount++;
nodeWithAssignedId = node;
assignedId = id;
assignedId = node.getAttributeValue('id');
}
if (tagName === 'style') {

3
test/autotests/render/error-variable-id-root-node/template.marko
View File

@ -1,3 +0,0 @@
$ var id = 'abc123';
<div id=id/>

6
test/autotests/render/error-variable-id-root-node/test.js
View File

@ -1,6 +0,0 @@
var expect = require('chai').expect;
exports.checkError = function(e) {
var message = e.toString();
expect(message).to.contain('https://github.com/marko-js/marko/wiki/Error:-Dynamic-root-HTML-element-id-attribute');
};

2
test/autotests/render/shorthand-div-id-dynamic/expected.html
View File

@ -1 +1 @@
<div><div style="color: red;" id="foo-Frank">Hello Frank!</div></div>
<div style="color: red;" id="foo-Frank">Hello Frank!</div>

5
test/autotests/render/shorthand-div-id-dynamic/template.marko
View File

@ -1,3 +1,2 @@
div
div#foo-${input.name} style="color: red;"
-- Hello ${input.name}!
div#foo-${input.name} style="color: red;"
-- Hello ${input.name}!