diff --git a/src/components/taglib/TransformHelper/handleRootNodes.js b/src/components/taglib/TransformHelper/handleRootNodes.js index dc3aacfc8..c37db496c 100644 --- a/src/components/taglib/TransformHelper/handleRootNodes.js +++ b/src/components/taglib/TransformHelper/handleRootNodes.js @@ -199,16 +199,9 @@ module.exports = function handleRootNodes() { hasLegacyExplicitBind = true; } else { if (node.hasAttribute('id')) { - let id = node.getAttributeValue('id'); - - if (id && id.type !== 'Literal') { - context.addError('Root HTML element should not have a dynamic `id` attribute. See: https://github.com/marko-js/marko/wiki/Error:-Dynamic-root-HTML-element-id-attribute'); - return; - } - hasIdCount++; nodeWithAssignedId = node; - assignedId = id; + assignedId = node.getAttributeValue('id'); } if (tagName === 'style') { diff --git a/test/autotests/render/error-variable-id-root-node/template.marko b/test/autotests/render/error-variable-id-root-node/template.marko deleted file mode 100644 index dca5a9008..000000000 --- a/test/autotests/render/error-variable-id-root-node/template.marko +++ /dev/null @@ -1,3 +0,0 @@ -$ var id = 'abc123'; - -
diff --git a/test/autotests/render/error-variable-id-root-node/test.js b/test/autotests/render/error-variable-id-root-node/test.js deleted file mode 100644 index b0ce803e3..000000000 --- a/test/autotests/render/error-variable-id-root-node/test.js +++ /dev/null @@ -1,6 +0,0 @@ -var expect = require('chai').expect; - -exports.checkError = function(e) { - var message = e.toString(); - expect(message).to.contain('https://github.com/marko-js/marko/wiki/Error:-Dynamic-root-HTML-element-id-attribute'); -}; diff --git a/test/autotests/render/shorthand-div-id-dynamic/expected.html b/test/autotests/render/shorthand-div-id-dynamic/expected.html index 41b8f8a2c..da125c09e 100644 --- a/test/autotests/render/shorthand-div-id-dynamic/expected.html +++ b/test/autotests/render/shorthand-div-id-dynamic/expected.html @@ -1 +1 @@ -
Hello Frank!
+
Hello Frank!
\ No newline at end of file diff --git a/test/autotests/render/shorthand-div-id-dynamic/template.marko b/test/autotests/render/shorthand-div-id-dynamic/template.marko index a43f3c15c..f485ac337 100644 --- a/test/autotests/render/shorthand-div-id-dynamic/template.marko +++ b/test/autotests/render/shorthand-div-id-dynamic/template.marko @@ -1,3 +1,2 @@ -div - div#foo-${input.name} style="color: red;" - -- Hello ${input.name}! +div#foo-${input.name} style="color: red;" + -- Hello ${input.name}! \ No newline at end of file