archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Fix return value of 'jerry_api_get_object_field_value'

Browse Source 
Fixed the return value to return false when the field does
not exist as the documentation says.

Related issue: #1041

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
This commit is contained in:
László Langó 2016-05-06 21:07:19 +02:00 committed by Akos Kiss
parent 2a5468a2ac
commit fe3c269e99
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
jerry-core/jerry.c
View File

@ -1225,19 +1225,23 @@ jerry_api_get_object_field_value_sz (jerry_api_object_t *object_p, /**< object *
ecma_string_t *field_name_str_p = ecma_new_ecma_string_from_utf8 ((lit_utf8_byte_t *) field_name_p,
(lit_utf8_size_t) field_name_size);
ecma_value_t get_completion = ecma_op_object_get (object_p,
field_name_str_p);
ecma_value_t field_value = ecma_op_object_get (object_p, field_name_str_p);
if (!ecma_is_value_error (get_completion))
if (!ecma_is_value_error (field_value))
{
jerry_api_convert_ecma_value_to_api_value (field_value_p, get_completion);
jerry_api_convert_ecma_value_to_api_value (field_value_p, field_value);
if (ecma_is_value_undefined (field_value))
{
is_successful = false;
}
}
else
{
is_successful = false;
}
ecma_free_value (get_completion);
ecma_free_value (field_value);
ecma_deref_ecma_string (field_name_str_p);

5
tests/unit/test-api.c
View File

@ -351,6 +351,11 @@ main (void)
JERRY_ASSERT (sz == 0);
jerry_api_release_value (&args[0]);
// Get global.boo (non-existing field)
is_ok = jerry_api_get_object_field_value (global_obj_p, (jerry_api_char_t *) "boo", &val_t);
JERRY_ASSERT (!is_ok);
JERRY_ASSERT (val_t.type == JERRY_API_DATA_TYPE_UNDEFINED);
// Get global.t
is_ok = jerry_api_get_object_field_value (global_obj_p, (jerry_api_char_t *)"t", &val_t);
JERRY_ASSERT (is_ok