archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Fix memory leak in AtomicModifyWrite (#4944)

Browse Source 
This patch fixes #4894.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik robert.fancsik@h-lab.eu
This commit is contained in:
Robert Fancsik 2022-01-14 10:05:39 +01:00 committed by GitHub
parent d681f201c2
commit 8fa7819c1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jerry-core/ecma/operations/ecma-atomics-object.c
View File

@ -192,6 +192,8 @@ ecma_atomic_read_modify_write (ecma_value_t typedarray, /**< typedArray argument
/* 9. */
uint32_t indexed_position = ecma_number_to_uint32 (idx) * element_size + offset;
ecma_free_value (idx);
JERRY_UNUSED (indexed_position);
JERRY_UNUSED (element_type);
JERRY_UNUSED (val);

19
tests/jerry/es.next/regression-test-issue-4894.js Normal file
View File

@ -0,0 +1,19 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
var sab = new SharedArrayBuffer(4);
var a = new Int32Array(sab);
/* TODO: replace with the correct value whenever AtomicModifyWrite is properly implemented */
assert(Atomics.add(a, -0, 1) === 0);