archive-gh-me/jerryscript
1
0
Fork 0
mirror of https://github.com/jerryscript-project/jerryscript.git synced 2025-12-15 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Fix invalid assertion CESU8-UTF8 buffer copy (#4946)

Browse Source 
The UTF8 buffer size can be smaller then the CESU8 string's size so the UTF8 output is may truncated. Therefore we cannot ensure that the CESU8 buffer is read until the end.
This patch fixes #4920.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik robert.fancsik@h-lab.eu
This commit is contained in:
Robert Fancsik 2022-01-14 10:03:47 +01:00 committed by GitHub
parent 85bad33fbf
commit d681f201c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jerry-core/lit/lit-strings.c
View File

@ -865,7 +865,7 @@ lit_convert_cesu8_string_to_utf8_string (const lit_utf8_byte_t *cesu8_string_p,
cesu8_cursor_p += read_size;
}
JERRY_ASSERT (cesu8_cursor_p == cesu8_end_p);
JERRY_ASSERT (cesu8_cursor_p <= cesu8_end_p);
JERRY_ASSERT (utf8_cursor_p <= utf8_end_p);
return (lit_utf8_byte_t) (utf8_cursor_p - utf8_string_p);

17
tests/jerry/fail/regression-test-issue-4920.js Normal file
View File

@ -0,0 +1,17 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
const v2 = String.fromCodePoint(1337);
const v4 = v2.padEnd(1337, v2);
const v7 = undefined[v4];