mirror of
https://github.com/jerryscript-project/jerryscript.git
synced 2025-12-15 16:29:21 +00:00
Fix shifting a negative value when using BigInts (#4429)
When shifting a negative BigInt value if the shift count is very "big" the result should be -1. eg.: ``` (-2n >> (2n*32n)) === -1n ``` Note: the `-2n >> (2n*31n)` already returned `-1n` prior this change. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com
This commit is contained in:
parent
6dfd02a08c
commit
7972386412
@ -1412,6 +1412,11 @@ ecma_bigint_shift (ecma_value_t left_value, /**< left BigInt value */
|
||||
{
|
||||
return ecma_bigint_raise_memory_error ();
|
||||
}
|
||||
else if (left_p->u.bigint_sign_and_size & ECMA_BIGINT_SIGN)
|
||||
{
|
||||
/* Shifting a negative value with a very big number to the right should be -1. */
|
||||
return ecma_bigint_create_from_digit (1, true);
|
||||
}
|
||||
|
||||
return ECMA_BIGINT_ZERO;
|
||||
}
|
||||
|
||||
47
tests/jerry/es.next/regression-test-issue-4341.js
Normal file
47
tests/jerry/es.next/regression-test-issue-4341.js
Normal file
@ -0,0 +1,47 @@
|
||||
// Copyright JS Foundation and other contributors, http://js.foundation
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
|
||||
/* Shifting a negative bigint value with a big number to the right should be -1n. */
|
||||
assert((-1n >> (2n ** 32n)) === -1n);
|
||||
assert((-1n >> 2n) === -1n);
|
||||
assert((-1n >> (2n ** 1n)) === -1n);
|
||||
assert((-5n >> 3n) === -1n);
|
||||
assert((-5n >> 4n) === -1n);
|
||||
assert((-(2n ** 32n) >> (2n ** 31n)) === -1n);
|
||||
assert((-(2n ** 32n) >> (2n ** 32n)) === -1n);
|
||||
assert((-(2n ** 32n) >> (2n ** 33n)) === -1n);
|
||||
assert((-(2n ** 32n) >> (2n ** 33000n)) === -1n);
|
||||
assert((-(2n ** 32n) >> 32n) === -1n);
|
||||
|
||||
/* (xn << -yn) ==> (xn >> yn) */
|
||||
assert((-1n << -(2n ** 32n)) === -1n);
|
||||
assert((-1n << -2n) === -1n);
|
||||
assert((-1n << -(2n ** 1n)) === -1n);
|
||||
assert((-5n << -3n) === -1n);
|
||||
assert((-5n << -4n) === -1n);
|
||||
assert((-(2n ** 32n) << -(2n ** 31n)) === -1n);
|
||||
assert((-(2n ** 32n) << -(2n ** 32n)) === -1n);
|
||||
assert((-(2n ** 32n) << -(2n ** 33n)) === -1n);
|
||||
assert((-(2n ** 32n) << -(2n ** 33000n)) === -1n);
|
||||
|
||||
/* Partialy related tests. */
|
||||
assert((-(2n ** 32n) >> 31n) === -2n);
|
||||
assert((-(2n ** 32n) >> 30n) === -4n);
|
||||
assert((-(2n ** 32n) >> 29n) === -8n);
|
||||
assert((-(2n ** 32n) >> 28n) === -16n);
|
||||
assert((-(2n ** 32n) >> 16n) === -65536n);
|
||||
assert((-(2n ** 32n) >> 2n) === -1073741824n);
|
||||
|
||||
assert((-5n >> 2n) === -2n);
|
||||
assert((-5n >> -4n) === -80n);
|
||||
Loading…
x
Reference in New Issue
Block a user