archive-gh-me/gitpod
1
0
Fork 0
mirror of https://github.com/gitpod-io/gitpod.git synced 2025-12-08 17:36:30 +00:00
Code Issues Projects Releases Wiki Activity

[prebuilds] remove loud error message

Browse Source
This commit is contained in:
Sven Efftinge 2021-09-07 13:06:10 +00:00 committed by Robo Quat
parent 03015215a9
commit dbc2576fbe
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
components/server/ee/src/prebuilds/prebuilt-status-maintainer.ts
View File

@ -100,6 +100,8 @@ export class PrebuildStatusMaintainer implements Disposable {
protected getConclusionFromPrebuildState(pws: PrebuiltWorkspace): "error" | "failure" | "pending" | "success" { protected getConclusionFromPrebuildState(pws: PrebuiltWorkspace): "error" | "failure" | "pending" | "success" {
if (pws.state === "aborted") { if (pws.state === "aborted") {
return "error"; return "error";
} else if (pws.state === "queued") {
return "pending";
} else if (pws.state === "timeout") { } else if (pws.state === "timeout") {
return "error"; return "error";
} else if (pws.state === "available" && !pws.error) { } else if (pws.state === "available" && !pws.error) {
@ -108,8 +110,7 @@ export class PrebuildStatusMaintainer implements Disposable {
// Not sure if this is the right choice - do we really want the check to fail if the prebuild fails? // Not sure if this is the right choice - do we really want the check to fail if the prebuild fails?
return "failure"; return "failure";
} else if (pws.state === "building") { } else if (pws.state === "building") {
log.warn("Should have updated prebuilt workspace updatable but prebuild still seems to be running. Resorting to error conclusion.", { pws }); return "pending";
return "error";
} else { } else {
log.warn("Should have updated prebuilt workspace updatable, but don't know how. Resorting to error conclusion.", { pws }); log.warn("Should have updated prebuilt workspace updatable, but don't know how. Resorting to error conclusion.", { pws });
return "error"; return "error";