From dbc2576fbe21b2b01dff984b51a155471efa5d4e Mon Sep 17 00:00:00 2001 From: Sven Efftinge Date: Tue, 7 Sep 2021 13:06:10 +0000 Subject: [PATCH] [prebuilds] remove loud error message --- .../server/ee/src/prebuilds/prebuilt-status-maintainer.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/components/server/ee/src/prebuilds/prebuilt-status-maintainer.ts b/components/server/ee/src/prebuilds/prebuilt-status-maintainer.ts index 5b6f556975..abc066bf53 100644 --- a/components/server/ee/src/prebuilds/prebuilt-status-maintainer.ts +++ b/components/server/ee/src/prebuilds/prebuilt-status-maintainer.ts @@ -100,6 +100,8 @@ export class PrebuildStatusMaintainer implements Disposable { protected getConclusionFromPrebuildState(pws: PrebuiltWorkspace): "error" | "failure" | "pending" | "success" { if (pws.state === "aborted") { return "error"; + } else if (pws.state === "queued") { + return "pending"; } else if (pws.state === "timeout") { return "error"; } else if (pws.state === "available" && !pws.error) { @@ -108,8 +110,7 @@ export class PrebuildStatusMaintainer implements Disposable { // Not sure if this is the right choice - do we really want the check to fail if the prebuild fails? return "failure"; } else if (pws.state === "building") { - log.warn("Should have updated prebuilt workspace updatable but prebuild still seems to be running. Resorting to error conclusion.", { pws }); - return "error"; + return "pending"; } else { log.warn("Should have updated prebuilt workspace updatable, but don't know how. Resorting to error conclusion.", { pws }); return "error";