archive-gh-me/gitbeaker
1
0
Fork 0
mirror of https://github.com/jdalrymple/gitbeaker.git synced 2026-01-18 15:55:30 +00:00
Code Issues Projects Releases Wiki Activity

Handle position arguments correctly (#2423)

Browse Source
This commit is contained in:
Justin Dalrymple 2022-03-19 23:49:05 -04:00 committed by GitHub
parent 36cb7857a9
commit 0bf87da2a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
packages/core/src/templates/ResourceDiscussions.ts
View File

@ -81,15 +81,25 @@ export class ResourceDiscussions<C extends boolean = false> extends BaseResource
resourceId: string | number,
resource2Id: string | number,
body: string,
options?: BaseRequestOptions,
{ position, ...options }: { position?: Record<string, unknown> } & BaseRequestOptions = {},
) {
const opts = { ...options };
if (position) {
opts.isForm = true;
opts.body = body;
Object.entries(position).forEach(([k, v]) => {
opts[`position[${k}]`] = v;
});
} else {
opts.query = { body };
}
return RequestHelper.post<DiscussionSchema>()(
this,
endpoint`${resourceId}/${this.resource2Type}/${resource2Id}/discussions`,
{
query: { body },
...options,
},
opts,
);
}