From 0bf87da2a95bafcf80cdca6b277256d7b0facc59 Mon Sep 17 00:00:00 2001 From: Justin Dalrymple Date: Sat, 19 Mar 2022 23:49:05 -0400 Subject: [PATCH] Handle position arguments correctly (#2423) --- .../core/src/templates/ResourceDiscussions.ts | 20 ++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/packages/core/src/templates/ResourceDiscussions.ts b/packages/core/src/templates/ResourceDiscussions.ts index 32551502..f3923841 100644 --- a/packages/core/src/templates/ResourceDiscussions.ts +++ b/packages/core/src/templates/ResourceDiscussions.ts @@ -81,15 +81,25 @@ export class ResourceDiscussions extends BaseResource resourceId: string | number, resource2Id: string | number, body: string, - options?: BaseRequestOptions, + { position, ...options }: { position?: Record } & BaseRequestOptions = {}, ) { + const opts = { ...options }; + + if (position) { + opts.isForm = true; + opts.body = body; + + Object.entries(position).forEach(([k, v]) => { + opts[`position[${k}]`] = v; + }); + } else { + opts.query = { body }; + } + return RequestHelper.post()( this, endpoint`${resourceId}/${this.resource2Type}/${resource2Id}/discussions`, - { - query: { body }, - ...options, - }, + opts, ); }