* Pass unknown props through to the div element
This fits common React conventions and allows using attributes such as `data-testid` for testing purposes.
Related changes:
- Adding HTMLAttributes<HTMLDivElement> to EChartsReactProps meant that EChartsReactProps was no longer usable as a `Record<string, unknown>`, which caused problems for the `pick` function. (See https://stackoverflow.com/q/65799316/25507.). I updated the pick function to use a generic type instead.
- Add [ignoreRestSiblings](https://eslint.org/docs/latest/rules/no-unused-vars#ignorerestsiblings) so ESLint is happy with the new code.
- Fix an unrelated Prettier warning in `componentDidUpdate`.
There's a slight risk of backwards-incompatible changes in this release: IF the user previously passed unknown props (e.g., due to typos or mistaken props spreads), they were ignored, but they're now passed through to the div element.
Fixes#546
* Update tests
* Code review
`initEchartsInstance` attached a handler for the `"finish"` event. If
`componentDidUpdate` is called between attaching the handler, and firing
the handler and the `onEvents` prop changed, this will fire
`"offEvents"` which will remove the handler for the `"finish"` event.
This means the finish handler never fires, so the chart auto-resize is
not attached, and the ready event handler never fires.
Instead, only remove the events that are on the previous props, and
leave the `"finish"` callback alone.
* chore: bump version to 3.0.4 and update ECharts dependency to 6.0.0 (#601)
* docs: update README to reflect ECharts version support for v6.0.0
* fix: standardize formatting and improve code readability in dynamic, simple, and theme examples
* chore: update npm install script
---------
Co-authored-by: tangweikun <819573105@qq.com>
Co-authored-by: hustcc <i@hust.cc>
* Add locale to Opts type
as available in echarts v5
* Add example of using Opts.locale to the demo website
Co-authored-by: Sylvain Thénault <sylvain.thenault@lowatt.fr>
