Add Dividers to Missing Places.

Previously, some sections of the app did not have dividers. This fixes
that.
This commit is contained in:
Jedi Burrell 2017-05-13 07:56:02 -04:00
parent 1af46965b7
commit 8adb0b6ca4
30 changed files with 30 additions and 0 deletions

View File

@ -61,6 +61,7 @@ public class FeedsFragment extends BaseFragment<FeedsMvp.View, FeedsPresenter> i
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (getPresenter().getEvents().isEmpty() && !getPresenter().isApiCalled()) {
onRefresh();

View File

@ -156,6 +156,7 @@ refresh.setRefreshing(true);
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
recycler.addKeyLineDivider();
if (savedInstanceState != null) {

View File

@ -51,6 +51,7 @@ public class GistsFragment extends BaseFragment<GistsMvp.View, GistsPresenter> i
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (getPresenter().getGists().isEmpty() && !getPresenter().isApiCalled()) {
onRefresh();

View File

@ -68,6 +68,7 @@ public class GistCommentsFragment extends BaseFragment<GistCommentsMvp.View, Gis
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
recycler.addNormalSpacingDivider();
if (getPresenter().getComments().isEmpty() && !getPresenter().isApiCalled()) {

View File

@ -66,6 +66,7 @@ public class GistFilesListFragment extends BaseFragment<GistFilesListMvp.View, G
}
if (!filesListModel.isEmpty()) {
recycler.setAdapter(new GistFilesAdapter(filesListModel, getPresenter()));
recycler.addKeyLineDivider();
}
}

View File

@ -132,6 +132,7 @@ refresh.setRefreshing(true);
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (savedInstanceState == null || (getPresenter().getIssues().isEmpty() && !getPresenter().isApiCalled())) {
onRefresh();

View File

@ -68,6 +68,7 @@ public class OrgListDialogFragment extends BaseDialogFragment<OrgListDialogMvp.V
recycler.setEmptyView(stateLayout, refresh);
adapter = new UsersAdapter(getPresenter().getOrgs());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
if (savedInstanceState == null) {
getPresenter().onLoadOrgs();
}

View File

@ -158,6 +158,7 @@ refresh.setRefreshing(true);
recycler.addDivider();
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (savedInstanceState == null || (getPresenter().getPullRequests().isEmpty() && !getPresenter().isApiCalled())) {
onRefresh();

View File

@ -93,6 +93,7 @@ public class AllNotificationsFragment extends BaseFragment<AllNotificationsMvp.V
stateLayout.setOnReloadListener(v -> onRefresh());
recycler.setEmptyView(stateLayout, refresh);
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addDivider(NotificationsViewHolder.class);
if (savedInstanceState == null || !getPresenter().isApiCalled()) {
onRefresh();

View File

@ -80,6 +80,7 @@ public class UnreadNotificationsFragment extends BaseFragment<UnreadNotification
stateLayout.setOnReloadListener(v -> onRefresh());
recycler.setEmptyView(stateLayout, refresh);
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addDivider(NotificationsViewHolder.class);
if (savedInstanceState == null || !getPresenter().isApiCalled()) {
onRefresh();

View File

@ -63,6 +63,7 @@ public class PinnedReposFragment extends BaseFragment<PinnedReposMvp.View, Pinne
stateLayout.setEmptyText(R.string.empty_pinned_repos);
recycler.setEmptyView(stateLayout, refresh);
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
refresh.setOnRefreshListener(() -> getPresenter().onReload());
stateLayout.setOnReloadListener(v -> getPresenter().onReload());
if (savedInstanceState == null) {

View File

@ -68,6 +68,7 @@ public class ProfileFollowersFragment extends BaseFragment<ProfileFollowersMvp.V
adapter = new UsersAdapter(getPresenter().getFollowers());
adapter.setListener(getPresenter());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
recycler.addKeyLineDivider();
if (getPresenter().getFollowers().isEmpty() && !getPresenter().isApiCalled()) {

View File

@ -59,6 +59,7 @@ public class ProfileGistsFragment extends BaseFragment<ProfileGistsMvp.View, Pro
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
recycler.addDivider();
if (getPresenter().getGists().isEmpty() && !getPresenter().isApiCalled()) {

View File

@ -65,6 +65,7 @@ public class OrgFeedsFragment extends BaseFragment<OrgFeedsMvp.View, OrgFeedsPre
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (getPresenter().getEvents().isEmpty() && !getPresenter().isApiCalled()) {
onRefresh();

View File

@ -68,6 +68,7 @@ public class OrgReposFragment extends BaseFragment<OrgReposMvp.View, OrgReposPre
adapter = new ReposAdapter(getPresenter().getRepos(), false);
adapter.setListener(getPresenter());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
recycler.addDivider();
if (getPresenter().getRepos().isEmpty() && !getPresenter().isApiCalled()) {

View File

@ -68,6 +68,7 @@ public class ProfileReposFragment extends BaseFragment<ProfileReposMvp.View, Pro
adapter = new ReposAdapter(getPresenter().getRepos(), false);
adapter.setListener(getPresenter());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
recycler.addDivider();
if (getPresenter().getRepos().isEmpty() && !getPresenter().isApiCalled()) {

View File

@ -68,6 +68,7 @@ public class ProfileStarredFragment extends BaseFragment<ProfileStarredMvp.View,
adapter = new ReposAdapter(getPresenter().getRepos(), true);
adapter.setListener(getPresenter());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
recycler.addDivider();
if (getPresenter().getRepos().isEmpty() && !getPresenter().isApiCalled()) {

View File

@ -105,6 +105,7 @@ public class RepoCommitsFragment extends BaseFragment<RepoCommitsMvp.View, RepoC
stateLayout.setOnReloadListener(this);
refresh.setOnRefreshListener(this);
recycler.setEmptyView(stateLayout, refresh);
recycler.addKeyLineDivider();
adapter = new CommitsAdapter(getPresenter().getCommits());
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());

View File

@ -66,6 +66,7 @@ public class CommitCommentsFragments extends BaseFragment<CommitCommentsMvp.View
stateLayout.setEmptyText(R.string.no_comments);
recycler.setEmptyView(stateLayout, refresh);
recycler.setItemViewCacheSize(30);
recycler.addKeyLineDivider();
refresh.setOnRefreshListener(this);
stateLayout.setOnReloadListener(this);
adapter = new IssuePullsTimelineAdapter(getPresenter().getComments(), this, true, this);

View File

@ -63,6 +63,7 @@ public class CommitFilesFragment extends BaseFragment<CommitFilesMvp.View, Commi
refresh.setEnabled(false);
stateLayout.setEmptyText(R.string.no_files);
recycler.setEmptyView(stateLayout, refresh);
recycler.addKeyLineDivider();
adapter = new CommitFilesAdapter(getPresenter().getFiles(), this);
adapter.setListener(getPresenter());
recycler.setAdapter(adapter);

View File

@ -67,6 +67,7 @@ public class RepoContributorsFragment extends BaseFragment<RepoContributorsMvp.V
stateLayout.setOnReloadListener(this);
refresh.setOnRefreshListener(this);
recycler.setEmptyView(stateLayout, refresh);
recycler.addKeyLineDivider();
adapter = new UsersAdapter(getPresenter().getUsers(), true);
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());

View File

@ -121,6 +121,7 @@ public class RepoFilesFragment extends BaseFragment<RepoFilesMvp.View, RepoFiles
refresh.setOnRefreshListener(this);
stateLayout.setOnReloadListener(v -> onRefresh());
recycler.setEmptyView(stateLayout, refresh);
recycler.addKeyLineDivider();
adapter = new RepoFilesAdapter(getPresenter().getFiles());
adapter.setListener(getPresenter());
recycler.setAdapter(adapter);

View File

@ -89,6 +89,7 @@ public class LabelsDialogFragment extends BaseDialogFragment<LabelsMvp.View, Lab
@Override protected void onFragmentCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
stateLayout.setEmptyText(R.string.no_labels);
recycler.setEmptyView(stateLayout);
recycler.addKeyLineDivider();
title.setText(R.string.labels);
add.setVisibility(View.VISIBLE);
List<LabelModel> list = getArguments().getParcelableArrayList(BundleConstant.ITEM);

View File

@ -79,6 +79,7 @@ public class CreateLabelDialogFragment extends BaseDialogFragment<CreateLabelMvp
}
;
recycler.setAdapter(new LabelColorsAdapter(Arrays.asList(getResources().getStringArray(R.array.label_colors)), getPresenter()));
recycler.addKeyLineDivider();
toolbar.setTitle(R.string.create_label);
toolbar.setNavigationIcon(R.drawable.ic_clear);
toolbar.setNavigationOnClickListener(item -> dismiss());

View File

@ -102,6 +102,7 @@ public class MilestoneDialogFragment extends BaseFragment<MilestoneMvp.View, Mil
adapter.setListener(getPresenter());
recycler.setEmptyView(stateLayout, refresh);
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
if (savedInstanceState == null || (getPresenter().getMilestones().isEmpty() && !getPresenter().isApiCalled())) {
getPresenter().onLoadMilestones(login, repo);
}

View File

@ -100,6 +100,7 @@ public class RepoClosedIssuesFragment extends BaseFragment<RepoIssuesMvp.View, R
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (savedInstanceState == null) {
getPresenter().onFragmentCreated(getArguments(), IssueState.closed);

View File

@ -103,6 +103,7 @@ public class RepoOpenedIssuesFragment extends BaseFragment<RepoIssuesMvp.View, R
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (savedInstanceState == null) {
getPresenter().onFragmentCreated(getArguments(), IssueState.open);

View File

@ -92,6 +92,7 @@ public class RepoPullRequestFragment extends BaseFragment<RepoPullRequestMvp.Vie
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (savedInstanceState == null) {
getPresenter().onFragmentCreated(getArguments());

View File

@ -73,6 +73,7 @@ public class PullRequestCommitsFragment extends BaseFragment<PullRequestCommitsM
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (savedInstanceState == null) {
getPresenter().onFragmentCreated(getArguments());

View File

@ -77,6 +77,7 @@ public class PullRequestFilesFragment extends BaseFragment<PullRequestFilesMvp.V
adapter.setListener(getPresenter());
getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal());
recycler.setAdapter(adapter);
recycler.addKeyLineDivider();
recycler.addOnScrollListener(getLoadMore());
if (savedInstanceState == null) {
getPresenter().onFragmentCreated(getArguments());