From 8adb0b6ca4dc885e20383d02da7e7380a6d21bae Mon Sep 17 00:00:00 2001 From: Jedi Burrell Date: Sat, 13 May 2017 07:56:02 -0400 Subject: [PATCH] Add Dividers to Missing Places. Previously, some sections of the app did not have dividers. This fixes that. --- .../main/java/com/fastaccess/ui/modules/feeds/FeedsFragment.java | 1 + .../ui/modules/filter/issues/fragment/FilterIssueFragment.java | 1 + .../main/java/com/fastaccess/ui/modules/gists/GistsFragment.java | 1 + .../ui/modules/gists/gist/comments/GistCommentsFragment.java | 1 + .../ui/modules/gists/gist/files/GistFilesListFragment.java | 1 + .../com/fastaccess/ui/modules/main/issues/MyIssuesFragment.java | 1 + .../fastaccess/ui/modules/main/orgs/OrgListDialogFragment.java | 1 + .../ui/modules/main/pullrequests/MyPullRequestFragment.java | 1 + .../ui/modules/notification/all/AllNotificationsFragment.java | 1 + .../modules/notification/unread/UnreadNotificationsFragment.java | 1 + .../com/fastaccess/ui/modules/pinned/PinnedReposFragment.java | 1 + .../ui/modules/profile/followers/ProfileFollowersFragment.java | 1 + .../ui/modules/profile/gists/ProfileGistsFragment.java | 1 + .../ui/modules/profile/org/feeds/OrgFeedsFragment.java | 1 + .../ui/modules/profile/org/repos/OrgReposFragment.java | 1 + .../ui/modules/profile/repos/ProfileReposFragment.java | 1 + .../ui/modules/profile/starred/ProfileStarredFragment.java | 1 + .../ui/modules/repos/code/commit/RepoCommitsFragment.java | 1 + .../code/commit/details/comments/CommitCommentsFragments.java | 1 + .../repos/code/commit/details/files/CommitFilesFragment.java | 1 + .../repos/code/contributors/RepoContributorsFragment.java | 1 + .../ui/modules/repos/code/files/RepoFilesFragment.java | 1 + .../ui/modules/repos/extras/labels/LabelsDialogFragment.java | 1 + .../repos/extras/labels/create/CreateLabelDialogFragment.java | 1 + .../modules/repos/extras/milestone/MilestoneDialogFragment.java | 1 + .../ui/modules/repos/issues/issue/RepoClosedIssuesFragment.java | 1 + .../ui/modules/repos/issues/issue/RepoOpenedIssuesFragment.java | 1 + .../pull_requests/pull_request/RepoPullRequestFragment.java | 1 + .../pull_request/details/commits/PullRequestCommitsFragment.java | 1 + .../pull_request/details/files/PullRequestFilesFragment.java | 1 + 30 files changed, 30 insertions(+) diff --git a/app/src/main/java/com/fastaccess/ui/modules/feeds/FeedsFragment.java b/app/src/main/java/com/fastaccess/ui/modules/feeds/FeedsFragment.java index 408d1939..998c6f07 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/feeds/FeedsFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/feeds/FeedsFragment.java @@ -61,6 +61,7 @@ public class FeedsFragment extends BaseFragment i adapter.setListener(getPresenter()); getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal()); recycler.setAdapter(adapter); + recycler.addKeyLineDivider(); recycler.addOnScrollListener(getLoadMore()); if (getPresenter().getEvents().isEmpty() && !getPresenter().isApiCalled()) { onRefresh(); diff --git a/app/src/main/java/com/fastaccess/ui/modules/filter/issues/fragment/FilterIssueFragment.java b/app/src/main/java/com/fastaccess/ui/modules/filter/issues/fragment/FilterIssueFragment.java index da0ba192..f5b42f5a 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/filter/issues/fragment/FilterIssueFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/filter/issues/fragment/FilterIssueFragment.java @@ -156,6 +156,7 @@ refresh.setRefreshing(true); adapter.setListener(getPresenter()); getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal()); recycler.setAdapter(adapter); + recycler.addKeyLineDivider(); recycler.addOnScrollListener(getLoadMore()); recycler.addKeyLineDivider(); if (savedInstanceState != null) { diff --git a/app/src/main/java/com/fastaccess/ui/modules/gists/GistsFragment.java b/app/src/main/java/com/fastaccess/ui/modules/gists/GistsFragment.java index 4411d3b1..2926e756 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/gists/GistsFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/gists/GistsFragment.java @@ -51,6 +51,7 @@ public class GistsFragment extends BaseFragment i adapter.setListener(getPresenter()); getLoadMore().setCurrent_page(getPresenter().getCurrentPage(), getPresenter().getPreviousTotal()); recycler.setAdapter(adapter); + recycler.addKeyLineDivider(); recycler.addOnScrollListener(getLoadMore()); if (getPresenter().getGists().isEmpty() && !getPresenter().isApiCalled()) { onRefresh(); diff --git a/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsFragment.java b/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsFragment.java index 701fee4a..a04a6218 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsFragment.java @@ -68,6 +68,7 @@ public class GistCommentsFragment extends BaseFragment onRefresh()); recycler.setEmptyView(stateLayout, refresh); recycler.setAdapter(adapter); + recycler.addKeyLineDivider(); recycler.addDivider(NotificationsViewHolder.class); if (savedInstanceState == null || !getPresenter().isApiCalled()) { onRefresh(); diff --git a/app/src/main/java/com/fastaccess/ui/modules/notification/unread/UnreadNotificationsFragment.java b/app/src/main/java/com/fastaccess/ui/modules/notification/unread/UnreadNotificationsFragment.java index fda0c7dc..79b0fb51 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/notification/unread/UnreadNotificationsFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/notification/unread/UnreadNotificationsFragment.java @@ -80,6 +80,7 @@ public class UnreadNotificationsFragment extends BaseFragment onRefresh()); recycler.setEmptyView(stateLayout, refresh); recycler.setAdapter(adapter); + recycler.addKeyLineDivider(); recycler.addDivider(NotificationsViewHolder.class); if (savedInstanceState == null || !getPresenter().isApiCalled()) { onRefresh(); diff --git a/app/src/main/java/com/fastaccess/ui/modules/pinned/PinnedReposFragment.java b/app/src/main/java/com/fastaccess/ui/modules/pinned/PinnedReposFragment.java index 3496dc04..08c4d412 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/pinned/PinnedReposFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/pinned/PinnedReposFragment.java @@ -63,6 +63,7 @@ public class PinnedReposFragment extends BaseFragment getPresenter().onReload()); stateLayout.setOnReloadListener(v -> getPresenter().onReload()); if (savedInstanceState == null) { diff --git a/app/src/main/java/com/fastaccess/ui/modules/profile/followers/ProfileFollowersFragment.java b/app/src/main/java/com/fastaccess/ui/modules/profile/followers/ProfileFollowersFragment.java index 984bc6bb..96ceb73b 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/profile/followers/ProfileFollowersFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/profile/followers/ProfileFollowersFragment.java @@ -68,6 +68,7 @@ public class ProfileFollowersFragment extends BaseFragment onRefresh()); recycler.setEmptyView(stateLayout, refresh); + recycler.addKeyLineDivider(); adapter = new RepoFilesAdapter(getPresenter().getFiles()); adapter.setListener(getPresenter()); recycler.setAdapter(adapter); diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/LabelsDialogFragment.java b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/LabelsDialogFragment.java index a32bba0c..d73b59aa 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/LabelsDialogFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/LabelsDialogFragment.java @@ -89,6 +89,7 @@ public class LabelsDialogFragment extends BaseDialogFragment list = getArguments().getParcelableArrayList(BundleConstant.ITEM); diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/create/CreateLabelDialogFragment.java b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/create/CreateLabelDialogFragment.java index 95aa2e5a..f3d1d64f 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/create/CreateLabelDialogFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/create/CreateLabelDialogFragment.java @@ -79,6 +79,7 @@ public class CreateLabelDialogFragment extends BaseDialogFragment dismiss()); diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/milestone/MilestoneDialogFragment.java b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/milestone/MilestoneDialogFragment.java index 9794fcef..10028031 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/milestone/MilestoneDialogFragment.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/milestone/MilestoneDialogFragment.java @@ -102,6 +102,7 @@ public class MilestoneDialogFragment extends BaseFragment