Fix typo in RenderService (#658)

This commit is contained in:
Justin Starry 2019-09-24 23:01:45 -04:00 committed by GitHub
parent dd59cf0392
commit f794d555e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions

View File

@ -73,6 +73,7 @@
- #### 🛠 Fixes
- Fixed JS typo in RenderService. This was causing animation frames to not be dropped correctly. [[@jstarry], [#658](https://github.com/yewstack/yew/pull/658)]
- Fixed `VNode` orphaning bug when destroying `VTag` elements. This caused some `Component`s to not be properly destroyed when they should have been. [[@hgzimmerman], [#651](https://github.com/yewstack/yew/pull/651)]
- Fix mishandling of Properties `where` clause in derive_props macro [[@astraw], [#640](https://github.com/yewstack/yew/pull/640)]

View File

@ -54,7 +54,7 @@ impl Task for RenderTask {
let handle = self.0.take().expect("tried to cancel render twice");
js! { @(no_return)
var handle = @{handle};
cancelAnimationFrame(handle.timeout_id);
cancelAnimationFrame(handle.render_id);
handle.callback.drop();
}
}