archive-gh-me/yew
1
0
Fork 0
mirror of https://github.com/yewstack/yew.git synced 2025-12-08 21:26:25 +00:00
Code Issues Projects Releases Wiki Activity

fix: link all outstanding TODO items to a ticket (#949)

Browse Source 
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
This commit is contained in:
Matthew Fisher 2020-02-15 04:52:33 -08:00 committed by GitHub
parent 12da2b5119
commit df14a9fc3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.rustfmt.toml Normal file
View File

@ -0,0 +1,2 @@
report_todo = "Unnumbered"
report_fixme = "Unnumbered"

18
src/agent.rs
View File

@ -272,7 +272,7 @@ impl Discoverer for Context {
let bridge = LOCAL_AGENTS_POOL.with(|pool| {
match pool.borrow_mut().entry::<LocalAgent<AGN>>() {
anymap::Entry::Occupied(mut entry) => {
// TODO Insert callback!
// TODO(#940): Insert callback!
entry.get_mut().create_bridge(callback)
}
anymap::Entry::Vacant(entry) => {
@ -423,7 +423,7 @@ impl Discoverer for Private {
let msg = FromWorker::<AGN::Output>::unpack(&data);
match msg {
FromWorker::WorkerLoaded => {
// TODO Send `Connected` message
// TODO(#948): Send `Connected` message
}
FromWorker::ProcessOutput(id, output) => {
assert_eq!(id.raw_id(), SINGLETON_ID.raw_id());
@ -431,7 +431,7 @@ impl Discoverer for Private {
}
}
};
// TODO Need somethig better...
// TODO(#947): Need somethig better...
let name_of_resource = AGN::name_of_resource();
let worker = js! {
var worker = new Worker(@{name_of_resource});
@ -463,7 +463,7 @@ impl<AGN: Agent> fmt::Debug for PrivateBridge<AGN> {
impl<AGN: Agent> Bridge<AGN> for PrivateBridge<AGN> {
fn send(&mut self, msg: AGN::Input) {
// TODO Important! Implement.
// TODO(#937): Important! Implement.
// Use a queue to collect a messages if an instance is not ready
// and send them to an agent when it will reported readiness.
let msg = ToWorker::ProcessInput(SINGLETON_ID, msg).pack();
@ -478,7 +478,7 @@ impl<AGN: Agent> Bridge<AGN> for PrivateBridge<AGN> {
impl<AGN: Agent> Drop for PrivateBridge<AGN> {
fn drop(&mut self) {
// TODO Send `Destroy` message.
// TODO(#946): Send `Destroy` message.
}
}
@ -525,7 +525,7 @@ impl Discoverer for Public {
let bridge = REMOTE_AGENTS_POOL.with(|pool| {
match pool.borrow_mut().entry::<RemoteAgent<AGN>>() {
anymap::Entry::Occupied(mut entry) => {
// TODO Insert callback!
// TODO(#945): Insert callback!
entry.get_mut().create_bridge(callback)
}
anymap::Entry::Vacant(entry) => {
@ -537,7 +537,7 @@ impl Discoverer for Public {
let msg = FromWorker::<AGN::Output>::unpack(&data);
match msg {
FromWorker::WorkerLoaded => {
// TODO Send `Connected` message
// TODO(#944): Send `Connected` message
let _ = REMOTE_AGENTS_LOADED.with(|local| {
local.borrow_mut().insert(TypeId::of::<AGN>())
});
@ -615,7 +615,7 @@ impl<AGN: Agent> PublicBridge<AGN> {
}
fn send_to_remote<AGN: Agent>(worker: &Value, msg: ToWorker<AGN::Input>) {
// TODO Important! Implement.
// TODO(#937): Important! Implement.
// Use a queue to collect a messages if an instance is not ready
// and send them to an agent when it will reported readiness.
let msg = msg.pack();
@ -822,7 +822,7 @@ impl<AGN: Agent> Clone for AgentLink<AGN> {
struct AgentRunnable<AGN> {
agent: Option<AGN>,
// TODO Use agent field to control create message this flag
// TODO(#939): Use agent field to control create message this flag
destroyed: bool,
}

2
src/html/mod.rs
View File

@ -50,7 +50,7 @@ pub trait Component: Sized + 'static {
/// Called by rendering loop.
fn view(&self) -> Html;
/// Called for finalization on the final point of the component's lifetime.
fn destroy(&mut self) {} // TODO Replace with `Drop`
fn destroy(&mut self) {} // TODO(#941): Replace with `Drop`
}
/// A type which expected as a result of `view` function implementation.

2
src/services/reader.rs
View File

@ -108,7 +108,7 @@ impl ReaderService {
let from = position;
let to = cmp::min(position + chunk_size, total_size);
position = to;
// TODO Implement `slice` method in `stdweb`
// TODO(#942): Implement `slice` method in `stdweb`
let blob: Blob = (js! {
return @{file}.slice(@{from as u32}, @{to as u32});
})

2
src/virtual_dom/mod.rs
View File

@ -166,7 +166,7 @@ enum Reform {
Before(Option<Node>),
}
// TODO What about to implement `VDiff` for `Element`?
// TODO(#938): What about to implement `VDiff` for `Element`?
// In makes possible to include ANY element into the tree.
// `Ace` editor embedding for example?

2
src/virtual_dom/vtag.rs
View File

@ -428,7 +428,7 @@ impl VDiff for VTag {
self.apply_diffs(&ancestor);
// Every render it removes all listeners and attach it back later
// TODO Compare references of handler to do listeners update better
// TODO(#943): Compare references of handler to do listeners update better
if let Some(ancestor) = ancestor.as_mut() {
for handle in ancestor.captured.drain(..) {
handle.remove();