archive-gh-me/yew
1
0
Fork 0
mirror of https://github.com/yewstack/yew.git synced 2025-12-08 21:26:25 +00:00
Code Issues Projects Releases Wiki Activity

Assert there are no circular references (#3025)

Browse Source 
* assert there are no circular references

the check is costly in release builds and should always fail
note that the current PartialEq impl is *not* symmetric!
should be fixed as well, with an improved design

* remove internal test for cyclic node refs

wasm_bindgen does not yet support #[should_panic]
see also https://github.com/rustwasm/wasm-bindgen/issues/2286
This commit is contained in:
WorldSEnder 2022-12-10 15:36:59 +00:00 committed by GitHub
parent d7f988055f
commit 57f45e2c81
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
packages/yew/src/html/mod.rs
View File

@ -134,9 +134,10 @@ mod feat_csr {
/// Link a downstream `NodeRef`
pub(crate) fn link(&self, node_ref: Self) {
// Avoid circular references
if self == &node_ref {
return;
}
debug_assert!(
self != &node_ref,
"no circular references allowed! Report this as a bug in yew"
);
let mut this = self.0.borrow_mut();
this.node = None;
@ -203,30 +204,3 @@ mod feat_hydration {
pub fn create_portal(child: Html, host: Element) -> Html {
VNode::VPortal(VPortal::new(child, host))
}
#[cfg(target_arch = "wasm32")]
#[cfg(test)]
mod tests {
use gloo::utils::document;
use wasm_bindgen_test::{wasm_bindgen_test as test, wasm_bindgen_test_configure};
use super::*;
wasm_bindgen_test_configure!(run_in_browser);
#[test]
fn self_linking_node_ref() {
let node: Node = document().create_text_node("test node").into();
let node_ref = NodeRef::new(node.clone());
let node_ref_2 = NodeRef::new(node.clone());
// Link to self
node_ref.link(node_ref.clone());
assert_eq!(node, node_ref.get().unwrap());
// Create cycle of two node refs
node_ref.link(node_ref_2.clone());
node_ref_2.link(node_ref);
assert_eq!(node, node_ref_2.get().unwrap());
}
}