archive-gh-me/wgpu
1
0
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2025-12-08 21:26:17 +00:00
Code Issues Projects Releases Wiki Activity

[hlsl-out] error on unimplemented non-struct push constants (#7545)

Browse Source
This commit is contained in:
Teodor Tanasoaia 2025-04-15 19:12:28 +02:00 committed by GitHub
parent 62d4e82149
commit ffc920b9ae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
naga/src/back/hlsl/writer.rs
View File

@ -966,6 +966,15 @@ impl<'a, W: fmt::Write> super::Writer<'a, W> {
// Push constants need to be assigned a binding explicitly by the consumer
// since naga has no way to know the binding from the shader alone
if global.space == crate::AddressSpace::PushConstant {
match module.types[global.ty].inner {
TypeInner::Struct { .. } => {}
_ => {
return Err(Error::Unimplemented(format!(
"push-constant '{name}' has non-struct type; tracked by: https://github.com/gfx-rs/wgpu/issues/5683"
)));
}
}
let target = self
.options
.push_constants_target