archive-gh-me/wgpu
1
0
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2025-12-08 21:26:17 +00:00
Code Issues Projects Releases Wiki Activity

Improve error message when image write without format used (#8294)

Browse Source
This commit is contained in:
Connor Fitzgerald 2025-10-06 13:25:25 -04:00 committed by GitHub
parent e73d0558f0
commit ad15442b89
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
naga/src/front/spv/error.rs
View File

@ -107,6 +107,8 @@ pub enum Error {
InvalidGlobalVar(crate::Expression), InvalidGlobalVar(crate::Expression),
#[error("invalid image/sampler expression {0:?}")] #[error("invalid image/sampler expression {0:?}")]
InvalidImageExpression(crate::Expression), InvalidImageExpression(crate::Expression),
#[error("image write without format is not currently supported. See https://github.com/gfx-rs/wgpu/issues/6797")]
InvalidImageWriteType,
#[error("invalid image base type {0:?}")] #[error("invalid image base type {0:?}")]
InvalidImageBaseType(Handle<crate::Type>), InvalidImageBaseType(Handle<crate::Type>),
#[error("invalid image {0:?}")] #[error("invalid image {0:?}")]

4
naga/src/front/spv/mod.rs
View File

@ -5635,7 +5635,7 @@ impl<I: Iterator<Item = u32>> Frontend<I> {
let is_depth = self.next()?; let is_depth = self.next()?;
let is_array = self.next()? != 0; let is_array = self.next()? != 0;
let is_msaa = self.next()? != 0; let is_msaa = self.next()? != 0;
let _is_sampled = self.next()?; let is_sampled = self.next()?;
let format = self.next()?; let format = self.next()?;
let dim = map_image_dim(dim)?; let dim = map_image_dim(dim)?;
@ -5670,6 +5670,8 @@ impl<I: Iterator<Item = u32>> Frontend<I> {
format: map_image_format(format)?, format: map_image_format(format)?,
access: crate::StorageAccess::default(), access: crate::StorageAccess::default(),
} }
} else if is_sampled == 2 {
return Err(Error::InvalidImageWriteType);
} else { } else {
crate::ImageClass::Sampled { crate::ImageClass::Sampled {
kind, kind,