archive-gh-me/wgpu
1
0
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2025-12-08 21:26:17 +00:00
Code Issues Projects Releases Wiki Activity

[wgsl-out] Generate correct code for bit complement on integers.

Browse Source 
Remove incorrect special case for `UnaryOperator::Not` on vectors.
This commit is contained in:
Jim Blandy 2023-10-09 10:51:11 -07:00 committed by Teodor Tanasoaia
parent 1b485ea925
commit 9eb3a1dc8a
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/back/wgsl/writer.rs
View File

@ -1600,13 +1600,10 @@ impl<W: Write> Writer<W> {
let unary = match op { let unary = match op {
crate::UnaryOperator::Negate => "-", crate::UnaryOperator::Negate => "-",
crate::UnaryOperator::Not => { crate::UnaryOperator::Not => {
match *func_ctx.resolve_type(expr, &module.types) { match func_ctx.resolve_type(expr, &module.types).scalar_kind() {
TypeInner::Scalar { Some(crate::ScalarKind::Sint) | Some(crate::ScalarKind::Uint) => "~",
kind: crate::ScalarKind::Bool, Some(crate::ScalarKind::Bool) => "!",
.. _ => return Err(Error::Custom("validation failure".to_string())),
}
| TypeInner::Vector { .. } => "!",
_ => "~",
} }
} }
}; };

4
tests/out/wgsl/operators.wgsl
View File

@ -128,8 +128,8 @@ fn arithmetic() {
fn bit() { fn bit() {
let flip0_ = ~(1); let flip0_ = ~(1);
let flip1_ = ~(1u); let flip1_ = ~(1u);
let flip2_ = !(vec2(1)); let flip2_ = ~(vec2(1));
let flip3_ = !(vec3(1u)); let flip3_ = ~(vec3(1u));
let or0_ = (2 | 1); let or0_ = (2 | 1);
let or1_ = (2u | 1u); let or1_ = (2u | 1u);
let or2_ = (vec2(2) | vec2(1)); let or2_ = (vec2(2) | vec2(1));