archive-gh-me/wgpu
1
0
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2025-12-08 21:26:17 +00:00
Code Issues Projects Releases Wiki Activity

Review checklist: suggest checking insertions expected to be new. (#7245)

Browse Source 
Suggest checking that PRs assert that insertions into sets or maps
expected to be adding new values didn't actually just replace some
existing value.

Bug #7048 and its several duplicates would have been caught sooner if
the insertion of the new spill temporary into the `spilled_composites`
table had asserted that there was no existing spill variable for that
expression.
This commit is contained in:
Jim Blandy 2025-02-27 16:30:18 -08:00 committed by GitHub
parent d6ca412732
commit 3297e9f108
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/review-checklist.md
View File

@ -34,6 +34,9 @@ satisfying way to address in a more robust way.
- [ ] If your change iterates over a collection, did you ensure the - [ ] If your change iterates over a collection, did you ensure the
order of iteration was deterministic? Using `HashMap` and order of iteration was deterministic? Using `HashMap` and
`HashSet` is fine, as long as you don't iterate over it. `HashSet` is fine, as long as you don't iterate over it.
- [ ] If you insert elements into a set or map that you expect are not
already present, did you make an assertion about `insert`'s
return value?
### WGSL Extensions ### WGSL Extensions