archive-gh-me/vitest
1
0
Fork 0
mirror of https://github.com/vitest-dev/vitest.git synced 2026-02-01 17:36:51 +00:00
Code Issues Projects Releases Wiki Activity

fix: always display serialized error, even if it doesn't have stack (#2829)

Browse Source
This commit is contained in:
Vladimir 2023-02-08 08:12:05 +01:00 committed by GitHub
parent 570c639e4e
commit ab5f892706
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/vitest/src/node/error.ts
View File

@ -188,9 +188,6 @@ function printStack(
errorProperties: Record<string, unknown>,
onStack?: ((stack: ParsedStack) => void),
) {
if (!stack.length)
return
const logger = ctx.logger
for (const frame of stack) {
@ -200,7 +197,8 @@ function printStack(
logger.error(color(` ${c.dim(F_POINTER)} ${[frame.method, c.dim(`${path}:${frame.line}:${frame.column}`)].filter(Boolean).join(' ')}`))
onStack?.(frame)
}
logger.error()
if (stack.length)
logger.error()
const hasProperties = Object.keys(errorProperties).length > 0
if (hasProperties) {
logger.error(c.red(c.dim(divider())))

2
packages/vitest/src/utils/tasks.ts
View File

@ -10,7 +10,7 @@ export function hasBenchmark(suite: Arrayable<Suite>): boolean {
export function hasFailedSnapshot(suite: Arrayable<Task>): boolean {
return getTests(suite).some((s) => {
return s.result?.errors?.some(e => e.message.match(/Snapshot .* mismatched/))
return s.result?.errors?.some(e => e && e.message && e.message.match(/Snapshot .* mismatched/))
})
}