typeorm

mirror of https://github.com/typeorm/typeorm.git synced 2025-12-08 21:26:23 +00:00

History

fix: resolve array modification bug in QueryRunner drop methods (#11564 )

* fix: resolve array modification bug in QueryRunner drop methods

Fix iteration bug in QueryRunner implementations where dropping multiple
database objects (columns, indices, foreign keys, unique constraints) would
skip elements due to in-place array modification during iteration.

The issue occurred when methods like dropColumns(), dropIndices(),
dropForeignKeys(), and dropUniqueConstraints() iterated over arrays while
simultaneously modifying them by removing elements. This caused a classic
"off-by-one" iteration bug where alternate elements would be skipped.

Changes:
- Update all affected QueryRunner drop methods to iterate over a shallow
  copy of the input array using [...array] spread syntax
- Add comprehensive regression tests in test/github-issues/11563/
- Test coverage includes all affected drivers: Postgres, MySQL, SQL Server,
  Oracle, CockroachDB, Spanner, SAP, and Aurora MySQL

Affected drivers:
- SpannerQueryRunner
- PostgresQueryRunner
- MysqlQueryRunner
- SqlServerQueryRunner
- OracleQueryRunner
- CockroachQueryRunner
- SapQueryRunner
- AuroraMysqlQueryRunner

Closes #11563

* fix: create multiple indices same column

* chore: functional tests instead of github issues

2025-07-09 08:23:47 +02:00

benchmark

test: remove unused type parameter from decorators (#11412 )

2025-04-14 09:25:31 -06:00

core

fixing failing test

2023-04-06 10:57:00 +05:00

functional

fix: resolve array modification bug in QueryRunner drop methods (#11564 )

2025-07-09 08:23:47 +02:00

github-issues

fix: preserve useIndex when cloning a QueryExpressionMap (or a QueryBuilder) (#10679 )