diff --git a/CHANGELOG.md b/CHANGELOG.md index 83c7b08e8..259322cdc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,7 @@ Now naming strategy should be registered by passing naming strategy instance dir * env variable names for connection were changed (`TYPEORM_DRIVER_TYPE` has been renamed to `TYPEORM_CONNECTION`, some other renaming). More env variable names you can find in `ConnectionOptionsEnvReader` class. * some api changes in `ConnectionManager` and `createConnection` / `createConnections` methods of typeorm main entrypoint +* `usePool` option has been removed from connection options. Now connections are working only with connection pooling ### OTHER API CHANGES diff --git a/src/driver/DatabaseConnection.ts b/src/driver/DatabaseConnection.ts index bcd73eca6..498536f68 100644 --- a/src/driver/DatabaseConnection.ts +++ b/src/driver/DatabaseConnection.ts @@ -6,12 +6,12 @@ export interface DatabaseConnection { /** * Id of the connection. */ - readonly id: number; + id: number; /** * Native driver's connection object. */ - readonly connection: any; + connection: any; /** * Connection's transaction instance. diff --git a/src/driver/DriverOptions.ts b/src/driver/DriverOptions.ts index a23237983..aa701c0e7 100644 --- a/src/driver/DriverOptions.ts +++ b/src/driver/DriverOptions.ts @@ -57,15 +57,6 @@ export interface DriverOptions { */ storage?: string; - /** - * Indicates if connection pooling should be used or not. - * Be default it is enabled if its supported by a platform. - * Set to false to disable it. - * - * @todo: rename to disablePool? What about mongodb pool? - */ - usePool?: boolean; - /** * Extra connection options to be passed to the underlying driver. */ diff --git a/src/logger/Logger.ts b/src/logger/Logger.ts index 39fb7dc18..7d2e80fce 100644 --- a/src/logger/Logger.ts +++ b/src/logger/Logger.ts @@ -3,6 +3,8 @@ import {PlatformTools} from "../platform/PlatformTools"; /** * Performs logging of the events in TypeORM. + * + * todo: implement logging of too long running queries (there should be option to control max query execution time) */ export class Logger {