archive-gh-me/typeorm
1
0
Fork 0
mirror of https://github.com/typeorm/typeorm.git synced 2025-12-08 21:26:23 +00:00
Code Issues Projects Releases Wiki Activity

fixed issue when connection is not closed on validation error of the entity metadata schema

Browse Source
This commit is contained in:
Umed Khudoiberdiev 2016-11-23 18:34:55 +05:00
parent 85f19c0be4
commit 6c36c38fdb
1 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/connection/Connection.ts
View File

@ -171,7 +171,16 @@ export class Connection {
this._isConnected = true;
// build all metadatas registered in the current connection
this.buildMetadatas();
try {
this.buildMetadatas();
} catch (error) {
// if for some reason build metadata fail (for example validation error during entity metadata check)
// connection needs to be closed
await this.close();
throw error;
}
return this;
}
@ -464,6 +473,15 @@ export class Connection {
const namingStrategy = this.createNamingStrategy();
const lazyRelationsWrapper = this.createLazyRelationsWrapper();
// take imported event subscribers
if (this.subscriberClasses && this.subscriberClasses.length) {
getMetadataArgsStorage()
.entitySubscribers
.filterByTargets(this.subscriberClasses)
.map(metadata => getFromContainer(metadata.target))
.forEach(subscriber => this.entitySubscribers.push(subscriber));
}
// take imported entity listeners
if (this.entityClasses && this.entityClasses.length) {
getMetadataArgsStorage()
@ -491,15 +509,6 @@ export class Connection {
this.repositoryAggregators.push(new RepositoryAggregator(this, metadata));
});
}
// take imported event subscribers
if (this.subscriberClasses && this.subscriberClasses.length) {
getMetadataArgsStorage()
.entitySubscribers
.filterByTargets(this.subscriberClasses)
.map(metadata => getFromContainer(metadata.target))
.forEach(subscriber => this.entitySubscribers.push(subscriber));
}
}
/**