archive-gh-me/tapable
1
0
Fork 0
mirror of https://github.com/webpack/tapable.git synced 2026-02-01 16:07:39 +00:00
Code Issues Projects Releases Wiki Activity

fix: support to pass return type for waterfall hooks (#191)

Browse Source
This commit is contained in:
Alexander Akait 2025-08-22 15:21:59 +03:00 committed by GitHub
parent 2da9b214b1
commit 25a2864796
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/__tests__/AsyncSeriesHooks.js
View File

@ -100,6 +100,13 @@ describe("AsyncSeriesWaterfallHook", () => {
hook.tap("undefined", () => null);
return expect(hook.promise()).resolves.toBeNull();
});
it("should work with different types", async () => {
const hook = new AsyncSeriesWaterfallHook(["x"]);
hook.tap("number", () => 42);
hook.tap("string", () => "string");
return expect(hook.promise()).resolves.toBe("string");
});
});
describe("AsyncSeriesLoopHook", () => {

7
lib/__tests__/SyncWaterfallHook.js
View File

@ -59,6 +59,13 @@ describe("SyncWaterfallHook", () => {
return expect(hook.call()).toBeNull();
});
it("should work with different types", async () => {
const hook = new SyncWaterfallHook(["x"]);
hook.tap("number", () => 42);
hook.tap("string", () => "string");
return expect(hook.call()).toBe("string");
});
it("should allow to create sync hooks", async () => {
const hook = new SyncWaterfallHook(["arg1", "arg2"]);

6
tapable.d.ts vendored
View File

@ -94,8 +94,9 @@ export class SyncLoopHook<
> extends SyncHook<T, void, AdditionalOptions> {}
export class SyncWaterfallHook<
T,
R = AsArray<T>[0],
AdditionalOptions = UnsetAdditionalOptions
> extends SyncHook<T, AsArray<T>[0] | void, AdditionalOptions> {}
> extends SyncHook<T, R, AdditionalOptions> {}
declare class AsyncHook<
T,
@ -136,8 +137,9 @@ export class AsyncSeriesLoopHook<
> extends AsyncHook<T, void, AdditionalOptions> {}
export class AsyncSeriesWaterfallHook<
T,
R = AsArray<T>[0],
AdditionalOptions = UnsetAdditionalOptions
> extends AsyncHook<T, AsArray<T>[0] | void, AdditionalOptions> {}
> extends AsyncHook<T, R, AdditionalOptions> {}
type HookFactory<H> = (key: any, hook?: H) => H;