mirror of
https://github.com/tailwindlabs/tailwindcss.git
synced 2025-12-08 21:36:08 +00:00
b661614265
* enabled `optimizeUniversalDefaults` by default
This PR is done in a way so that the default is set to `true`, but you
can still disable it if it causes issues. In this case we do appreciate
an issue in that case 😅.
* update tests to use optimized universal selector
* update integration tests
* add dedicated tests for the optimized universal selector
* improve minimumImpactSelector algorithm
I think I cracked the algorithm, but I will probably need another pair
of eyes on the subject.
The current implementation works like this:
Prerequisites:
- The selector should already have been parsed using the selectorParser
from 'postcss-selector-parser'.
Algorithm:
1. Remove all of the pseudo classes from the list of nodes.
1.1. We do want to keep pseudo elements (E.g.: `::before`, `::first-line`, ...)
1.2. We do want to keep pseudo classes that contain nodes (E.g.:
`:not(...)`)
2. Reverse the list of nodes.
This will make it easier to search from the end to the start. For
example `.group:hover .group-hover` should result in `.group-hover`
not `.group`.
2.1. Find the index of the best match (class, id, attribute), and
convert the node if required. (E.g.: `span#app` -> `#app` => `[id="app"]`)
2.2. Remove the rest of the selector that is not important anymore
2.3. Re-join the left-over nodes together
* update tests using new algorithm
* also look for `tag` types
* take `tag` into account
* simplify logic
* add test to prove `rest.reverse()` in first case is required
In case we don't find a match (idx === -1), we use `rest.reverse()`.
However, it looks like you can just use `nodes` instead.
This is not entirely true, because the `rest` variable will contain only
the nodes that are not pseudo elements.
`*:hover` would result in `*:hover` instead of just `*`
* replace all nodes after > with a single universal selector
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
import chalk from 'chalk'
|
|
import log from './util/log'
|
|
|
|
let defaults = {
|
|
optimizeUniversalDefaults: true,
|
|
}
|
|
|
|
let featureFlags = {
|
|
future: [],
|
|
experimental: ['optimizeUniversalDefaults'],
|
|
}
|
|
|
|
export function flagEnabled(config, flag) {
|
|
if (featureFlags.future.includes(flag)) {
|
|
return config.future === 'all' || (config?.future?.[flag] ?? defaults[flag] ?? false)
|
|
}
|
|
|
|
if (featureFlags.experimental.includes(flag)) {
|
|
return (
|
|
config.experimental === 'all' || (config?.experimental?.[flag] ?? defaults[flag] ?? false)
|
|
)
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
function experimentalFlagsEnabled(config) {
|
|
if (config.experimental === 'all') {
|
|
return featureFlags.experimental
|
|
}
|
|
|
|
return Object.keys(config?.experimental ?? {}).filter(
|
|
(flag) => featureFlags.experimental.includes(flag) && config.experimental[flag]
|
|
)
|
|
}
|
|
|
|
export function issueFlagNotices(config) {
|
|
if (process.env.JEST_WORKER_ID !== undefined) {
|
|
return
|
|
}
|
|
|
|
if (experimentalFlagsEnabled(config).length > 0) {
|
|
let changes = experimentalFlagsEnabled(config)
|
|
.map((s) => chalk.yellow(s))
|
|
.join(', ')
|
|
|
|
log.warn('experimental-flags-enabled', [
|
|
`You have enabled experimental features: ${changes}`,
|
|
'Experimental features in Tailwind CSS are not covered by semver, may introduce breaking changes, and can change at any time.',
|
|
])
|
|
}
|
|
}
|
|
|
|
export default featureFlags
|