From 813aa4500958347ff020a8d792cab3a60bf1fed5 Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Wed, 6 Mar 2024 16:57:13 +0100 Subject: [PATCH] [v4] Improve CI by linting before installing playwright browsers (#13105) * improve CI by linting before building and intalling playwright browsers * move lint below build --- .github/workflows/ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8399c4b64..4dbbe9cbb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,6 +23,7 @@ jobs: - uses: pnpm/action-setup@v3 with: version: ^8.15.0 + - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v3 with: @@ -55,9 +56,6 @@ jobs: - name: Install dependencies run: pnpm install - - name: Install Playwright Browsers - run: npx playwright install --with-deps - - name: Build run: pnpm run build @@ -67,6 +65,9 @@ jobs: - name: Test run: pnpm run test + - name: Install Playwright Browsers + run: npx playwright install --with-deps + - name: Run Playwright tests run: npm run test:ui