Nate Fischer 6b3c7b1e44
refactor: don't expose tempdir in common.state (#903)
Previously, the cached `tempdir` value was stored in `common.state`.
Unlike the other `common.state` values, this isn't immediately useful to
other commands (they can just call the tempdir API). So, this moves the
cached value into `tempdir.js`.

This also adds a unit test for the caching behavior, and exposes
test-only helpers to verify this behavior.

Finally, this adds a note to `common.state` that values should generally
be considered read-only, since this can be important for customized
behavior. Although, I recognize our code base has one exception to this
rule (`echo()`), we should strive to maintain this.

Fixes #902
Test: Added a unit test.
2018-11-08 23:00:22 -08:00
..
2018-07-22 20:38:13 -07:00
2018-07-11 15:06:20 -07:00
2018-07-11 15:06:20 -07:00
2016-12-20 11:27:02 -08:00
2018-10-27 13:51:36 -07:00
2018-07-22 20:38:13 -07:00
2017-10-17 19:25:09 -07:00
2018-06-27 00:02:32 -07:00