archive-gh-me/shelljs
1
0
Fork 0
mirror of https://github.com/shelljs/shelljs.git synced 2026-01-25 16:07:37 +00:00
Code Issues Projects Releases Wiki Activity

Make shell.exec() treat process error return codes as shelljs errors

Browse Source
This commit is contained in:
Nils Bunger 2013-09-08 17:08:33 -07:00
parent cf9d4e0799
commit d97c34627c
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/exec.js
View File

@ -82,6 +82,10 @@ function execSync(cmd, opts) {
try { common.unlinkSync(codeFile); } catch(e) {}
try { common.unlinkSync(sleepFile); } catch(e) {}
// some shell return codes are defined as errors, per http://tldp.org/LDP/abs/html/exitcodes.html
if (code === 1 || code === 2 || code >= 126) {
common.error('Exec returned error code' + code, true);
}
// True if successful, false if not
var obj = {
code: code,

16
test/exec.js
View File

@ -22,6 +22,22 @@ assert.ok(shell.error());
var result = shell.exec('asdfasdf'); // could not find command
assert.ok(result.code > 0);
// Test 'fatal' mode for exec, temporarily overriding process.exit
var old_fatal = shell.config.fatal;
var old_exit = process.exit;
var exitcode = 9999;
process.exit = function (_exitcode) {
exitcode = _exitcode;
};
shell.config.fatal = true;
var result = shell.exec('asdfasdf'); // could not find command
assert.equal(exitcode, 1);
shell.config.fatal = old_fatal;
process.exit = old_exit;
//
// Valids