Nick Chisiu 16aa6581ab fix #1854 - update npm devDependencies packages (#1879)
* fix #1854 - added latest version of eslint-config-airbnb-base package

* fix #1854 - added latest npm shrinkwrap scheme

* fix #1854 - added latest npm coveralls package

* fix #1854 - added latest npm eslint package

* fix #1854 - added latest npm eslint-config-airbnb package

* fix #1854 - added latest npm eslint-plugin-import package

* fix #1854 - added latest npm eslint-plugin-jsx-a11y package

* fix #1854 - added latest npm eslint-plugin-react package

* fix #1854 - fixed estlint new-parens errors for integration test

* fix #1854 - fixed estlint new-parens errors for yaml parsers tests

* fix #1854 - fixed estlint max-len errors for util tests

* fix #1854 - disabled no-extraneous-dependencies on eslintrc for NodeJS 4 incapability on this feature

* fix #1854 - fixed eslint new-parens errors for Service tests

* fix #1854 - fixed eslint new-parens errors for Serverless tests

* fix #1854 - fixed eslint new-parens errors for plugin manager tests

* fix #1854 - fixed eslint new-parens errors for plugin tracking tests

* fix #1854 - fixed eslint new-parens errors for plugin package zipService lib

* fix #1854 - fixed eslint new-parens errors for plugin package zipService tests

* fix #1854 - fixed eslint trailing spaces errors for plugin package zipService lib

* fix #1854 - fixed eslint new-parens errors for plugin package cleanup  tests

* fix #1854 - fixed eslint new-parens errors for plugin create tests

* fix #1854 - fixed eslint dot same line expectation error on plugin aws logs index

* fix #1854 - fixed eslint operator assignment error on plugin aws logs index

* fix #1854 - fixed eslint dot location error on plugin aws invoke tests

* fix #1854 - fixed eslint new-parens error on plugin aws invoke tests

* fix #1854 - fixed eslint new-parens error on plugin aws deployFunction tests

* fix #1854 - fixed eslint new-parens error on plugin aws deploy uploadDeploymentPackage tests

* fix #1854 - fixed eslint new-parens error on plugin aws deploy updateStack tests

* fix #1854 - fixed eslint new-parens error on plugin aws deploy createStack tests

* fix #1854 - fixed eslint new-parens error on plugin aws deploy apiGateway lib deployment

* fix #1854 - fixed eslint unary typeof whitespace req error on Serverless Service class

* fix #1854 - fixed eslint unary typeof whitespace req error on Serverless Service class ( second fix )

* fix #1854 - fixed eslint no-lonely-if req error on Serverless Service class

* fix #1854 - disabled react/require-extension on eslintrc because it's deprecated

* fix #1854 - AwsCompileApigEvents #constructor() should resolve if no functions are given:
                 Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both.

* fix #1854 - createStack #postCreate() should resolve:
                 Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both.

* fix #1854 - emptyS3Bucket #deleteObjects() should resolve if objectsInBucket is empty:
                 Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both.

* fix #1854 - AwsInvoke #extendedValidate() should resolve if path is not given:
                 Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both.

* fix #1854 - #cleanup() should resolve if the .serverless directory is not present:
                 Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both.

* fix #1854 -#validate() should resolve if servicePath is given:
                Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both.

* fix #1854 -  Service #load() should resolve if no servicePath is found:
                 Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both.

* fix #1854 - added latest mocha package

* fix #1854 - added latest sinon npm package

* fix #1854 - serverless/lib/plugins/aws/deploy/tests/createStack.js 136:48  error  Missing semicolon  semi

* fix #1854 - serverless/lib/plugins/package/tests/cleanup.js 35:7  error  Missing semicolon  semi

* fix #1854 - serverless/lib/plugins/package/tests/validate.js 22:49  error  Missing semicolon  semi

* fix #1854 - added latest npm shrinkwrap

* fix #1854 - fixed no-extra-boolean-cast eslint error on aws deploy apiGateway methods

* fix #1854 - fixed  new-parens eslint error on serverless tests for Service class
2016-08-18 11:51:09 +02:00

179 lines
6.0 KiB
JavaScript

'use strict';
const expect = require('chai').expect;
const sinon = require('sinon');
const path = require('path');
const fs = require('fs');
const os = require('os');
const Package = require('../../../package');
const AwsDeployFunction = require('../');
const Serverless = require('../../../../Serverless');
const BbPromise = require('bluebird');
describe('AwsDeployFunction', () => {
let serverless;
let awsDeployFunction;
beforeEach(() => {
serverless = new Serverless();
serverless.servicePath = true;
serverless.service.environment = {
vars: {},
stages: {
dev: {
vars: {},
regions: {
'us-east-1': {
vars: {},
},
},
},
},
};
serverless.service.functions = {
first: {
handler: true,
},
};
const options = {
stage: 'dev',
region: 'us-east-1',
function: 'first',
functionObj: {
name: 'first',
},
};
serverless.init();
awsDeployFunction = new AwsDeployFunction(serverless, options);
});
describe('#constructor()', () => {
it('should have hooks', () => expect(awsDeployFunction.hooks).to.be.not.empty);
it('should set the provider variable to "aws"', () => expect(awsDeployFunction.provider)
.to.equal('aws'));
it('should set an empty options object if no options are given', () => {
const awsDeployFunctionWithEmptyOptions = new AwsDeployFunction(serverless);
expect(awsDeployFunctionWithEmptyOptions.options).to.deep.equal({});
});
it('should run promise chain in order', () => {
const checkIfFunctionExistsStub = sinon
.stub(awsDeployFunction, 'checkIfFunctionExists').returns(BbPromise.resolve());
const zipFunctionStub = sinon
.stub(awsDeployFunction, 'zipFunction').returns(BbPromise.resolve());
const deployFunctionStub = sinon
.stub(awsDeployFunction, 'deployFunction').returns(BbPromise.resolve());
const cleanupStub = sinon
.stub(awsDeployFunction, 'cleanup').returns(BbPromise.resolve());
return awsDeployFunction.hooks['deploy:function:deploy']().then(() => {
expect(checkIfFunctionExistsStub.calledOnce).to.be.equal(true);
expect(zipFunctionStub.calledAfter(checkIfFunctionExistsStub))
.to.be.equal(true);
expect(deployFunctionStub.calledAfter(zipFunctionStub))
.to.be.equal(true);
expect(cleanupStub.calledAfter(deployFunctionStub))
.to.be.equal(true);
awsDeployFunction.checkIfFunctionExists.restore();
awsDeployFunction.zipFunction.restore();
awsDeployFunction.deployFunction.restore();
awsDeployFunction.cleanup.restore();
});
});
});
describe('#checkIfFunctionExists()', () => {
it('it should throw error if function is not provided', () => {
serverless.service.functions = null;
expect(() => awsDeployFunction.checkIfFunctionExists()).to.throw(Error);
});
it('should check if the function is deployed', () => {
const getFunctionStub = sinon
.stub(awsDeployFunction.sdk, 'request').returns(BbPromise.resolve());
awsDeployFunction.serverless.service.functions = {
first: {
name: 'first',
handler: 'handler.first',
},
};
return awsDeployFunction.checkIfFunctionExists().then(() => {
expect(getFunctionStub.calledOnce).to.be.equal(true);
expect(getFunctionStub.calledWith(
awsDeployFunction.options.stage, awsDeployFunction.options.region)
);
expect(getFunctionStub.args[0][0]).to.be.equal('Lambda');
expect(getFunctionStub.args[0][1]).to.be.equal('getFunction');
expect(getFunctionStub.args[0][2].FunctionName).to.be.equal('first');
awsDeployFunction.sdk.request.restore();
});
});
});
describe('#zipFunction()', () => {
it('should zip the function', () => {
const pkg = new Package();
awsDeployFunction.pkg = pkg;
const zipServiceStub = sinon
.stub(pkg, 'zipService').returns(BbPromise.resolve());
return awsDeployFunction.zipFunction().then(() => {
expect(zipServiceStub.calledOnce).to.be.equal(true);
awsDeployFunction.pkg.zipService.restore();
});
});
});
describe('#deployFunction()', () => {
it('should deploy the function', () => {
// write a file to disc to simulate that the deployment artifact exists
const tmpDirPath = path.join(os.tmpdir(), (new Date()).getTime().toString());
const artifactFilePath = path.join(tmpDirPath, 'artifact.zip');
serverless.utils.writeFileSync(artifactFilePath, 'artifact.zip file content');
awsDeployFunction.serverless.service.package.artifact = artifactFilePath;
const updateFunctionCodeStub = sinon
.stub(awsDeployFunction.sdk, 'request').returns(BbPromise.resolve());
return awsDeployFunction.deployFunction().then(() => {
const data = fs.readFileSync(artifactFilePath);
expect(updateFunctionCodeStub.calledOnce).to.be.equal(true);
expect(updateFunctionCodeStub.calledWith(
awsDeployFunction.options.stage, awsDeployFunction.options.region)
);
expect(updateFunctionCodeStub.args[0][0]).to.be.equal('Lambda');
expect(updateFunctionCodeStub.args[0][1]).to.be.equal('updateFunctionCode');
expect(updateFunctionCodeStub.args[0][2].FunctionName).to.be.equal('first');
expect(updateFunctionCodeStub.args[0][2].ZipFile).to.deep.equal(data);
awsDeployFunction.sdk.request.restore();
});
});
});
describe('#cleanup()', () => {
it('should remove the temporary .serverless directory', () => {
const pkg = new Package();
awsDeployFunction.pkg = pkg;
const cleanupStub = sinon
.stub(pkg, 'cleanup').returns(BbPromise.resolve());
return awsDeployFunction.cleanup().then(() => {
expect(cleanupStub.calledOnce).to.be.equal(true);
awsDeployFunction.pkg.cleanup.restore();
});
});
});
});