mirror of
https://github.com/serverless/serverless.git
synced 2026-01-18 14:58:43 +00:00
79fe3adb85
When running sls rollback -t 1546961025152 the timestamp was being parsed as a string inside a Date Object. This would return an Invalid Date, therefore, failing to convert the timestamp into a valid date. In here we are checking to see if the date is already a valid one, otherwise convert the timestamp to a number and try again. We are checking first because most cases we don't want to convert to numbers. Fix #5664 Ps: We could add another check, if the date is still invalid, throw an Error, but that's not the scope of the issue. Signed-off-by: Luan <luan@luanmuniz.com.br>
96 lines
3.1 KiB
JavaScript
96 lines
3.1 KiB
JavaScript
'use strict';
|
|
|
|
const _ = require('lodash');
|
|
const BbPromise = require('bluebird');
|
|
const validate = require('../lib/validate');
|
|
const setBucketName = require('../lib/setBucketName');
|
|
const updateStack = require('../lib/updateStack');
|
|
const monitorStack = require('../lib/monitorStack');
|
|
const findAndGroupDeployments = require('../utils/findAndGroupDeployments');
|
|
|
|
class AwsRollback {
|
|
constructor(serverless, options) {
|
|
this.serverless = serverless;
|
|
this.options = options;
|
|
this.provider = this.serverless.getProvider('aws');
|
|
|
|
Object.assign(
|
|
this,
|
|
validate,
|
|
setBucketName,
|
|
updateStack,
|
|
monitorStack
|
|
);
|
|
|
|
this.hooks = {
|
|
'before:rollback:initialize': () => BbPromise.bind(this)
|
|
.then(this.validate),
|
|
'rollback:rollback': () => {
|
|
if (!this.options.timestamp) {
|
|
const command = this.serverless.pluginManager.spawn('deploy:list');
|
|
this.serverless.cli.log([
|
|
'Use a timestamp from the deploy list below to rollback to a specific version.',
|
|
'Run `sls rollback -t YourTimeStampHere`',
|
|
].join('\n'));
|
|
return command;
|
|
}
|
|
|
|
return BbPromise.bind(this)
|
|
.then(this.setBucketName)
|
|
.then(this.setStackToUpdate)
|
|
.then(this.updateStack);
|
|
},
|
|
};
|
|
}
|
|
|
|
setStackToUpdate() {
|
|
const service = this.serverless.service;
|
|
const serviceName = this.serverless.service.service;
|
|
const stage = this.provider.getStage();
|
|
const deploymentPrefix = this.provider.getDeploymentPrefix();
|
|
const prefix = `${deploymentPrefix}/${serviceName}/${stage}`;
|
|
|
|
return this.provider.request('S3',
|
|
'listObjectsV2',
|
|
{
|
|
Bucket: this.bucketName,
|
|
Prefix: prefix,
|
|
})
|
|
.then((response) => {
|
|
const deployments = findAndGroupDeployments(response, deploymentPrefix, serviceName, stage);
|
|
|
|
if (deployments.length === 0) {
|
|
const msg = 'Couldn\'t find any existing deployments.';
|
|
const hint = 'Please verify that stage and region are correct.';
|
|
return BbPromise.reject(`${msg} ${hint}`);
|
|
}
|
|
|
|
let date = new Date(this.options.timestamp);
|
|
|
|
// The if below is added due issues#5664 - Check it for more details
|
|
if (date instanceof Date === false || isNaN(date.valueOf())) {
|
|
date = new Date(Number(this.options.timestamp));
|
|
}
|
|
|
|
const dateString = `${date.getTime().toString()}-${date.toISOString()}`;
|
|
const exists = _.some(deployments, (deployment) => (
|
|
_.some(deployment, {
|
|
directory: dateString,
|
|
file: 'compiled-cloudformation-template.json',
|
|
})
|
|
));
|
|
|
|
if (!exists) {
|
|
const msg = `Couldn't find a deployment for the timestamp: ${this.options.timestamp}.`;
|
|
const hint = 'Please verify that the timestamp, stage and region are correct.';
|
|
return BbPromise.reject(`${msg} ${hint}`);
|
|
}
|
|
|
|
service.package.artifactDirectoryName = `${prefix}/${dateString}`;
|
|
return BbPromise.resolve();
|
|
});
|
|
}
|
|
}
|
|
|
|
module.exports = AwsRollback;
|