76 Commits

Author SHA1 Message Date
Frank Schmid
81c896bc12
Removed reintroduction of stage+region in request. Added options.
Delete bucket was still using them

Hopefully all :)

Further test fixes.

.... worked too long yesterday

Fixed Variable tests

Remove not used parameters from request() and add options with warning
2017-12-11 12:33:35 +01:00
Erik Erikson
df5dc28961 add tests to get to 100% line coverage
1. add tests that validate string value defaults in overrides.
2. add test of behavior when a javascript's export does not contain the attribute declared in the variable.
3. add tests of behavior when an SSM parameter is not found and the request to the SSM service fails.

add returns to tests that weren't returning their promises (and were thereby risking false positives.
2017-12-08 00:53:58 -08:00
Erik Erikson
32e660d94c add tests to validate that nested variables inside overwrites are resolved 2017-12-07 12:49:09 -08:00
Erik Erikson
6a0784ce2f add now passing "populate once" tests, use populate over render 2017-12-06 16:48:54 -08:00
Erik Erikson
c8ebe25968 fix build by adding `'use strict'; to generated 'async.load.js' 2017-12-06 16:38:51 -08:00
Erik Erikson
d6abd689b6 fix migrated tests 2017-12-06 16:20:17 -08:00
Erik Erikson
8c1fe6dfcc Refactor, simplify, correct, add tests
Increase name consistency
Improve names to be-what-they-are
Reduce cyclomatic complexity
Include overrides population fix
Add variable methods documentation
Add more tests around significant variable patterns/risky cases
2017-12-06 15:59:07 -08:00
Frank Schmid
8f70c13a9c
Merge branch 'master' into circular-vars 2017-12-07 00:22:55 +01:00
Frank Schmid
2e09606f13
Merge remote-tracking branch 'remotes/upstream/master' into circular-vars 2017-12-06 13:20:51 +01:00
Frank Schmid
8ff661835e
Merge branch 'master' into populate-default-objects 2017-12-06 12:34:50 +01:00
Erik Erikson
dea94bc310 Add significant variable usage corner cases 2017-12-05 14:31:00 -08:00
Frank Schmid
5526802a1b
Added request cache and queue to AWS provider
Make sure that requests are throttled. Use a queue for the requests.

Added new expected parameter to request() call in variables test

Added request cache tests
Check that request is indeed called 1000 times

Cache promises, not values

Use request cache for AWS variable requests

Use fromCallback instead of "new Promise" anti-pattern.

Added request cache to AWS provider
2017-12-05 12:39:39 +01:00
Frank Schmid
37340467ed
Populate objects if default syntax targets an object 2017-12-04 18:08:39 +01:00
Benjamin Forster
fae0ccb1d7 update variable name in test to be more descriptive 2017-12-01 10:40:23 +11:00
Benjamin Forster
6e6fea3fa2 update ssm cache to generic variable cache. 2017-12-01 10:33:30 +11:00
Benjamin Forster
382f6900e0 update test to show that cache is working 2017-11-30 10:08:23 +11:00
Benjamin Forster
33b666c431 add test 2017-11-29 17:49:52 +11:00
Frank Schmid
e823679340 Fixed package-lock and unit tests after rebase (conflicts) 2017-11-17 00:17:28 +01:00
Philipp Muens
9fd1c457d6 Fix stub setups and teardowns in tests 2017-11-17 00:04:21 +01:00
Eslam A. Hefnawy
535f425344 added tests 2017-11-17 00:00:58 +01:00
horike37
0bb444ac76 minor tweak 2017-11-09 01:27:09 +09:00
horike37
dbe02ab0e8 Merge branch 'master' of github.com:serverless/serverless 2017-11-08 10:30:50 +09:00
Frank Schmid
5744a08a91 Fixed #getValueFromFile():should work for absolute paths with ~ unit test 2017-11-07 12:21:06 +01:00
Frank Schmid
3e826ef598 Reworked remaining variable tests to use sinon chai notation 2017-11-07 11:49:07 +01:00
horike37
9cb43195be add test if symlink works 2017-11-07 09:36:20 +09:00
horike37
59290542c0 improve Variables test 2017-11-07 09:14:24 +09:00
horike37
21a64aed19 update test for that case 2017-11-07 00:00:40 +09:00
Basile Trujilllo [L0gIn]
188382f339 Add symlink variable file unit tests 2017-10-17 14:32:58 +02:00
Loren Gordon
629c073c6b Tests SSM variable syntax for all allowable characters 2017-09-13 07:14:49 -04:00
Loren Gordon
9746de39dd Expects string variables to fulfill promise 2017-09-07 09:39:31 -04:00
Loren Gordon
6088c9f494 Updates string syntax tests to call functions under test 2017-09-07 08:21:48 -04:00
Loren Gordon
5a7d14af09 Adds overwrite syntax support to SSM variable syntax
Check for the expected error message in the case the SSM parameter
does not exist and return `undefined`. Any other (unexpected) error
message still throws an exception.
2017-09-01 15:10:00 -04:00
Loren Gordon
ba14eb9ab2 Adds tests for SSM variable functionality 2017-09-01 12:54:04 -04:00
Philipp Muens
f8787d4289 Minor fixes 2017-08-21 13:35:04 +02:00
Philipp Muens
44aa158da9 Fix breaking test for custom variableSyntax usage 2017-08-21 13:19:08 +02:00
Philipp Muens
701187bc59 Update all variableSyntax usages 2017-08-21 13:11:29 +02:00
Toby Hede
33431cb45a Allow double-quoted and single-quoted variables
Empty string is now valid
2017-08-20 11:05:15 +10:00
Toby Hede
a1c8a37b9a Allow use of string as default values in variables 2017-08-18 09:07:29 +10:00
indieisaconcept
71f1aa09cb preserve context when executing exported function from .js file
The change ensures that when a .js file exported function is executed,
the original execution context is supplied in order to maintain "this".
2017-07-26 11:21:09 +10:00
Eslam λ Hefnawy
bb32b01f7a Merge pull request #3909 from jaikdean/variable-syntax-documentation-fix
Update example custom variable syntax to work with loading files
2017-07-12 19:42:18 +07:00
Philipp Muens
c67d60f5d6 Merge pull request #3888 from mangas/3629-fix-file-absolute-path
handle absolute paths in file()
2017-07-07 14:55:02 +02:00
Jaik Dean
c33c4f782a Update example alternate variable syntax to work with loading files 2017-07-06 16:42:08 +01:00
Filipe Azevedo
aab492f079 handle absolute paths with ~ in file() 2017-07-03 18:19:23 +01:00
Luke Herrington
1264dd015c
Improve usage and error handling of javascript variables. 2017-06-23 10:49:38 -07:00
Philipp Muens
0e4aceb704 Update error message 2017-06-11 21:14:12 +02:00
Philipp Muens
ee14ce9f36 Minor code changes and test improvements 2017-06-08 09:54:46 +02:00
Jeremy Benoist
ca202c5672
Throw an Error when requested variable does not exist
When we define a cf variable in serverless.yml and that variable wasn't output from the Cloudformation Outputs
a useless error was throw:

> Cannot read property 'OutputValue' of undefined

Now the error give more information:

> Trying to request a non variable from Cloudformation.
> Stack name: "some-stack" Requested variable: "DoestNotExist"
2017-06-06 17:18:33 +02:00
Sam Marks
aef89a51c7 Another follow-up on async vars. 2017-05-31 00:18:10 -04:00
Eslam λ Hefnawy
ddb99af627 Merge pull request #3592 from aoskotsky-amplify/master
Add support for S3 variables
2017-05-18 21:28:02 +07:00
Eslam A. Hefnawy
7503fa0bc5 fixed bug when using dot notation in yml keys 2017-05-15 22:05:04 +07:00