8 Commits

Author SHA1 Message Date
Erik Erikson
4ce75bb81c only print a final promise tracking report if a progress report was previously printed
This reduces the noise of this component.  See discussion at https://github.com/serverless/serverless/pull/6960#issuecomment-554515331
2019-11-15 13:03:22 -08:00
Mariusz Nowak
4d8246d5df
Revert "Add promise completion report and improve promise reporting verbiage" 2019-11-15 12:53:44 +01:00
Erik Erikson
6ed462b857 prettier fixes 2019-11-14 16:18:14 -08:00
Erik Erikson
263d8a7d93 add promise completion report and alter unsettled promise reporting verbiage
Fixes #4984
2019-11-14 15:38:42 -08:00
Mariusz Nowak
4944f471b1
Prettify 2019-06-26 12:43:01 +02:00
Mariusz Nowak
f191775cc9
Ensure to return after promises resolve 2019-05-20 12:09:45 +02:00
Erik Erikson
ffc7686465 fix pending promise test bugs 2018-02-16 18:46:28 -08:00
Erik Erikson
4400ffc9e4 fix #4311 & #4734, separate PromiseTracker, minutiae
#4311
  see prepopulateService - attempts to pre-populate the region and stage settings necessary for making a request to AWS, rejecting and dependencies thereon it runs into during that process
  see the `deep` variable work.  this was a knock-on effect of providing pre-population.  it actually represents an obscure class of bugs where the recursive population previously in getDeepValue caused the caller not to be in charge of population choices (thus fixing for pre-population) but also caused potential deadlocks resulting from getDeepValue creating circular dependencies.

#4734
  see splitByComma - a regex to do the splitting but ignore quoted commas was getting very deep and involved.  Instead, identify quoted string boundaries, then identify commas (including white space around them) and take those commas not contained by quotes as the locations for splitting the given string.  Trim the string as well (removing leading and trailing white space).
  add sophistication to the overwrite syntax, allowing for whitespace and repetitions (for robustness)
  add sophistication to the string ref syntax, allowing for use in identifying multiple quoted strings in a variable (i.e. for overwrites)

#NotCreated
  fix a bug I created earlier in the branch that caused reporting to be less informative (see renderMatches)

separate PromiseTracker
  move this class into its own file for the purpose of increasing testability and offering reuse

minutiae
  filter the properties given to populateVariables so as to avoid attempting resolution on non-variables.  Efficiency and noise reduction change.  Also cleans up the code (e.g. see populateObject and its use)
  cleaning of overwrite as a side effect
  offer variable cleaning as a idiom
  reorder the Variables.js `require`s to be in alphabetical order
2018-02-16 17:13:03 -08:00