From ff8a6cc71faea777e76fbab32a7d7689982a51aa Mon Sep 17 00:00:00 2001 From: John McKim Date: Tue, 30 Aug 2016 08:40:14 +1000 Subject: [PATCH] remove todo and ensure createstack returns promise --- lib/plugins/aws/deploy/compile/functions/index.js | 2 +- lib/plugins/aws/deploy/lib/createStack.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/plugins/aws/deploy/compile/functions/index.js b/lib/plugins/aws/deploy/compile/functions/index.js index 5af9932f1..be130ea09 100644 --- a/lib/plugins/aws/deploy/compile/functions/index.js +++ b/lib/plugins/aws/deploy/compile/functions/index.js @@ -106,7 +106,7 @@ class AwsCompileFunctions { const artifactFilePath = this.serverless.service.package.individually ? functionObject.artifact : this.serverless.service.package.artifact; - // TODO: + if (!artifactFilePath) { throw new Error(`No artifact path is set for function: ${functionLogicalName}`); } diff --git a/lib/plugins/aws/deploy/lib/createStack.js b/lib/plugins/aws/deploy/lib/createStack.js index 49e4c80ab..52f15a244 100644 --- a/lib/plugins/aws/deploy/lib/createStack.js +++ b/lib/plugins/aws/deploy/lib/createStack.js @@ -93,7 +93,8 @@ module.exports = { // just write the template to disk if a deployment should not be performed if (this.options.noDeploy) { - return this.writeCreateTemplateToDisk(); + return BbPromise.bind(this) + .then(this.writeCreateTemplateToDisk); } return this.sdk.request('CloudFormation',