From dec3d5ff40cd76f28ab10116f244a95b17d80abf Mon Sep 17 00:00:00 2001 From: Philipp Muens Date: Wed, 28 Aug 2019 13:30:14 +0200 Subject: [PATCH] Update docs / Fix typos --- docs/providers/aws/guide/plugins.md | 2 +- lib/classes/PluginManager.test.js | 34 ++++++++++++++--------------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/docs/providers/aws/guide/plugins.md b/docs/providers/aws/guide/plugins.md index f1d748fd6..934a61b09 100644 --- a/docs/providers/aws/guide/plugins.md +++ b/docs/providers/aws/guide/plugins.md @@ -197,7 +197,7 @@ module.exports = Deploy; ### Custom variable getters -As of version 1.51.0 of Serverless framework, you can officially implement your own variable types +As of version 1.52.0 of Serverless framework, you can officially implement your own variable types for use in `serverless.yml` config files. Example: diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js index 45e9be212..2c3630350 100644 --- a/lib/classes/PluginManager.test.js +++ b/lib/classes/PluginManager.test.js @@ -1039,8 +1039,8 @@ describe('PluginManager', () => { }); describe('#loadVariableResolvers()', () => { - it('should load the plugin variable getters with short sytnax', () => { - class VariableGetterPlugin { + it('should load the plugin variable resolvers with short sytnax', () => { + class VariableResolverPlugin { getTestVariable() { return Promise.resolve('testVariable'); } @@ -1053,7 +1053,7 @@ describe('PluginManager', () => { pluginManager.serverless.variables = { variableResolvers: [], }; - const pluginInstance = new VariableGetterPlugin(); + const pluginInstance = new VariableResolverPlugin(); pluginManager.loadVariableResolvers(pluginInstance); expect('test:asdfsd').to.match(pluginManager.serverless.variables.variableResolvers[0].regex); @@ -1066,8 +1066,8 @@ describe('PluginManager', () => { ); }); - it('should load the plugin variable getters with long syntax', () => { - class VariableGetterPlugin { + it('should load the plugin variable resolvers with long syntax', () => { + class VariableResolverPlugin { getTestVariable() { return Promise.resolve('testVariable'); } @@ -1080,7 +1080,7 @@ describe('PluginManager', () => { pluginManager.serverless.variables = { variableResolvers: [], }; - const pluginInstance = new VariableGetterPlugin(); + const pluginInstance = new VariableResolverPlugin(); pluginManager.loadVariableResolvers(pluginInstance); expect('test:asdfsd').to.match(pluginManager.serverless.variables.variableResolvers[0].regex); @@ -1093,8 +1093,8 @@ describe('PluginManager', () => { ); }); - it('should validate the plugin variable getters function', () => { - class VariableGetterPlugin { + it('should validate the plugin variable resolvers function', () => { + class VariableResolverPlugin { getTestVariable() { return Promise.resolve('testVariable'); } @@ -1107,14 +1107,14 @@ describe('PluginManager', () => { pluginManager.serverless.variables = { variableResolvers: [], }; - const pluginInstance = new VariableGetterPlugin(); + const pluginInstance = new VariableResolverPlugin(); expect(() => pluginManager.loadVariableResolvers(pluginInstance)).to.throw( - "Custom variable resolver for test defined by VariableGetterPlugin specifies a resolver that isn't a function: not a function" + "Custom variable resolver for test defined by VariableResolverPlugin specifies a resolver that isn't a function: not a function" ); }); - it('should load the plugin variable getters name if necessary', () => { - class VariableGetterPlugin { + it('should load the plugin variable resolvers name if necessary', () => { + class VariableResolverPlugin { getTestVariable() { return Promise.resolve('testVariable'); } @@ -1131,7 +1131,7 @@ describe('PluginManager', () => { pluginManager.serverless.variables = { variableResolvers: [], }; - const pluginInstance = new VariableGetterPlugin(); + const pluginInstance = new VariableResolverPlugin(); pluginManager.loadVariableResolvers(pluginInstance); expect('test:asdfsd').to.match(pluginManager.serverless.variables.variableResolvers[0].regex); @@ -1144,8 +1144,8 @@ describe('PluginManager', () => { ); }); - it('should validate the plugin variable getters name if necessary', () => { - class VariableGetterPlugin { + it('should validate the plugin variable resolvers name if necessary', () => { + class VariableResolverPlugin { getTestVariable() { return Promise.resolve('testVariable'); } @@ -1161,9 +1161,9 @@ describe('PluginManager', () => { pluginManager.serverless.variables = { variableResolvers: [], }; - const pluginInstance = new VariableGetterPlugin(); + const pluginInstance = new VariableResolverPlugin(); expect(() => pluginManager.loadVariableResolvers(pluginInstance)).to.throw( - /Custom variable resolver for test defined by VariableGetterPlugin specifies isDisabledAtPrepopulation but doesn't provide a string for a name/ + /Custom variable resolver for test defined by VariableResolverPlugin specifies isDisabledAtPrepopulation but doesn't provide a string for a name/ ); }); });