archive-gh-me/serverless
1
0
Fork 0
mirror of https://github.com/serverless/serverless.git synced 2026-01-25 15:07:39 +00:00
Code Issues Projects Releases Wiki Activity

fixed the bug resultTtlInSeconds defaults to 300 when set to 0

Browse Source
This commit is contained in:
horike37 2016-11-02 08:47:56 +09:00
parent b3a49d580c
commit cf441a4dbc
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/plugins/aws/deploy/compile/events/apiGateway/lib/authorizers.js
View File

@ -51,7 +51,8 @@ module.exports = {
throw new this.serverless.classes
.Error('Please provide either an authorizer name or ARN');
}
resultTtlInSeconds = Number.parseInt(authorizer.resultTtlInSeconds, 10) || 300;
resultTtlInSeconds = Number.parseInt(authorizer.resultTtlInSeconds, 10);
resultTtlInSeconds = Number.isNaN(resultTtlInSeconds) ? 300 : resultTtlInSeconds;
identitySource = authorizer.identitySource || 'method.request.header.Authorization';
} else {
const errorMessage = [

4
lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js
View File

@ -108,7 +108,7 @@ describe('#compileAuthorizers()', () => {
it('should create authorizer with the given config object', () => {
awsCompileApigEvents.serverless.service.functions.first.events[0].http.authorizer = {
name: 'authorizer',
resultTtlInSeconds: 400,
resultTtlInSeconds: 0,
identitySource: 'method.request.header.Custom',
identityValidationExpression: 'regex',
};
@ -117,7 +117,7 @@ describe('#compileAuthorizers()', () => {
expect(
awsCompileApigEvents.serverless.service.provider.compiledCloudFormationTemplate
.Resources.AuthorizerApiGatewayAuthorizer.Properties.AuthorizerResultTtlInSeconds
).to.equal(400);
).to.equal(0);
expect(
awsCompileApigEvents.serverless.service.provider.compiledCloudFormationTemplate