From cb6d22e3e06ffdc52aa6c95a2ff314cf3c596181 Mon Sep 17 00:00:00 2001 From: davidwells Date: Wed, 17 May 2017 09:28:31 -0700 Subject: [PATCH] lint all the things --- lib/classes/Utils.js | 2 +- lib/plugins/login/login.js | 8 +++++--- lib/plugins/logout/logout.js | 8 ++++---- lib/plugins/logout/logout.test.js | 2 +- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/lib/classes/Utils.js b/lib/classes/Utils.js index 1bb601764..80c1e34a4 100644 --- a/lib/classes/Utils.js +++ b/lib/classes/Utils.js @@ -178,7 +178,7 @@ class Utils { return resolve(); } const config = configUtils.getConfig(); - console.log(config.slsStats); + console.log(config.slsStats); // eslint-disable-line let userId = uuid.v1(); if (!this.fileExistsSync(statsEnabledFilePath)) { diff --git a/lib/plugins/login/login.js b/lib/plugins/login/login.js index 6b01bccc1..005560848 100644 --- a/lib/plugins/login/login.js +++ b/lib/plugins/login/login.js @@ -9,7 +9,7 @@ const jwtDecode = require('jwt-decode'); const chalk = require('chalk'); const getFrameworkId = require('../../utils/getFrameworkId'); const clearConsole = require('../../utils/clearConsole'); -const segment = require('../../utils/segment'); +// const segment = require('../../utils/segment'); const setConfig = require('../../utils/config').set; // const getConfig = require('../../utils/config').getConfig; @@ -57,6 +57,7 @@ class Login { opn(url, options).catch(() => {}); return true; } catch (err) { + // https://github.com/sindresorhus/log-symbols console.log('---------------------------'); // eslint-disable-line console.log(`🙈 ${chalk.red("Unable to open browser automatically")}`); // eslint-disable-line console.log(chalk.green("Please open your browser & open the URL below to login:")); // eslint-disable-line @@ -77,8 +78,9 @@ class Login { const state = `id%3D${frameworkId}`; // refresh token docs https://auth0.com/docs/tokens/preview/refresh-token#get-a-refresh-token const authorizeUrl = - `${config.AUTH0_URL}/authorize?response_type=code&scope=openid%20email%20nickname%20offline_access&` + - `client_id=${config.AUTH0_CLIENT_ID}&redirect_uri=${config.AUTH0_CALLBACK_URL}` + + `${config.AUTH0_URL}/authorize?response_type=code` + + '&scope=openid%20email%20nickname%20offline_access' + + `&client_id=${config.AUTH0_CLIENT_ID}&redirect_uri=${config.AUTH0_CALLBACK_URL}` + `&code_challenge=${verifierChallenge}&code_challenge_method=S256&state=${state}`; setTimeout(() => { diff --git a/lib/plugins/logout/logout.js b/lib/plugins/logout/logout.js index 9dcea15a0..579972ef3 100644 --- a/lib/plugins/logout/logout.js +++ b/lib/plugins/logout/logout.js @@ -1,6 +1,6 @@ 'use strict'; -const getFrameworkId = require('../../utils/getFrameworkId'); +// const getFrameworkId = require('../../utils/getFrameworkId'); // const segment = require('../../utils/segment'); const config = require('../../utils/config'); @@ -24,7 +24,7 @@ class Login { const configuration = config.getAll(); if (configuration && !configuration.auth) { - console.log('You are already logged out.'); + console.log('You are already logged out.'); // eslint-disable-line return; } const logout = () => { @@ -33,11 +33,11 @@ class Login { // that invalidate a refresh token in Auth0 (using the Auth0 Management API). // This endpoint should be called when the user runs `serverless logout` in the CLI. config.set('auth', null); - console.log('Successfully logged out.'); + console.log('Successfully logged out.'); // eslint-disable-line // Note no need to wait for any connections e.g. segment to close process.exit(0); } catch (e) { - console.log('Failed to logout. Please manually remove this file: '); + console.log('Failed to logout. Please manually remove this file: '); // eslint-disable-line // Note no need to wait for any connections e.g. segment to close process.exit(0); } diff --git a/lib/plugins/logout/logout.test.js b/lib/plugins/logout/logout.test.js index a1d93defc..4df6b059d 100644 --- a/lib/plugins/logout/logout.test.js +++ b/lib/plugins/logout/logout.test.js @@ -14,6 +14,6 @@ describe('Logout', () => { }); describe('#constructor()', () => { - it('should have commands', () => expect(login.commands).to.be.not.empty); + it('should have commands', () => expect(logout.commands).to.be.not.empty); }); });