From b069e09e9f5344caebef8d0109ac9932b6efbe29 Mon Sep 17 00:00:00 2001 From: Kevin Tardif Date: Mon, 19 Aug 2019 13:35:06 -0400 Subject: [PATCH] Updated logRetentionInDays checks --- .../aws/package/compile/events/apiGateway/lib/stage/index.js | 2 +- lib/plugins/aws/package/lib/mergeIamTemplates.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/stage/index.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/stage/index.js index 7e2cda737..64b6fbc78 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/stage/index.js +++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/stage/index.js @@ -142,7 +142,7 @@ function getLogGroupResource(service, stage, provider) { }; const logRetentionInDays = provider.getLogRetentionInDays(); - if (logRetentionInDays !== null) { + if (logRetentionInDays) { resource.Properties.RetentionInDays = logRetentionInDays; } diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.js b/lib/plugins/aws/package/lib/mergeIamTemplates.js index 2891bcb6a..2d97671ad 100644 --- a/lib/plugins/aws/package/lib/mergeIamTemplates.js +++ b/lib/plugins/aws/package/lib/mergeIamTemplates.js @@ -31,7 +31,7 @@ module.exports = { }; const logRetentionInDays = this.provider.getLogRetentionInDays(); - if (logRetentionInDays !== null) { + if (logRetentionInDays) { newLogGroup[logGroupLogicalId].Properties.RetentionInDays = logRetentionInDays; }