From ae4f094bc7abbe0c6bb8a4ce8281ca178a370004 Mon Sep 17 00:00:00 2001 From: "Eslam A. Hefnawy" Date: Fri, 26 Aug 2016 14:00:17 +0900 Subject: [PATCH] fix linting issues --- .../aws/deploy/compile/events/schedule/tests/index.js | 9 ++++++--- lib/plugins/aws/deploy/compile/functions/tests/index.js | 2 +- lib/plugins/aws/deploy/tests/createStack.js | 4 ---- lib/plugins/package/tests/zipService.js | 1 - 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/lib/plugins/aws/deploy/compile/events/schedule/tests/index.js b/lib/plugins/aws/deploy/compile/events/schedule/tests/index.js index 5de029123..e71842dfa 100644 --- a/lib/plugins/aws/deploy/compile/events/schedule/tests/index.js +++ b/lib/plugins/aws/deploy/compile/events/schedule/tests/index.js @@ -86,13 +86,16 @@ describe('AwsCompileScheduledEvents', () => { .provider.compiledCloudFormationTemplate.Resources.FirstEventsRuleSchedule3.Type ).to.equal('AWS::Events::Rule'); expect(awsCompileScheduledEvents.serverless.service - .provider.compiledCloudFormationTemplate.Resources.FirstLambdaPermissionEventsRuleSchedule1.Type + .provider.compiledCloudFormationTemplate.Resources + .FirstLambdaPermissionEventsRuleSchedule1.Type ).to.equal('AWS::Lambda::Permission'); expect(awsCompileScheduledEvents.serverless.service - .provider.compiledCloudFormationTemplate.Resources.FirstLambdaPermissionEventsRuleSchedule2.Type + .provider.compiledCloudFormationTemplate.Resources + .FirstLambdaPermissionEventsRuleSchedule2.Type ).to.equal('AWS::Lambda::Permission'); expect(awsCompileScheduledEvents.serverless.service - .provider.compiledCloudFormationTemplate.Resources.FirstLambdaPermissionEventsRuleSchedule3.Type + .provider.compiledCloudFormationTemplate.Resources + .FirstLambdaPermissionEventsRuleSchedule3.Type ).to.equal('AWS::Lambda::Permission'); }); diff --git a/lib/plugins/aws/deploy/compile/functions/tests/index.js b/lib/plugins/aws/deploy/compile/functions/tests/index.js index 7dc794973..1e3d62952 100644 --- a/lib/plugins/aws/deploy/compile/functions/tests/index.js +++ b/lib/plugins/aws/deploy/compile/functions/tests/index.js @@ -47,7 +47,7 @@ describe('AwsCompileFunctions', () => { ).to.deep.equal(IamRoleLambdaExecutionTemplate.IamRoleLambdaExecution); }); - it('should merge the IamPolicyLambdaExecution template into the CloudFormation template', () => { + it('should merge IamPolicyLambdaExecution template into the CloudFormation template', () => { awsCompileFunctions.compileFunctions(); // we check for the type here because a deep equality check will error out due to diff --git a/lib/plugins/aws/deploy/tests/createStack.js b/lib/plugins/aws/deploy/tests/createStack.js index aa5b2411d..13a3f1899 100644 --- a/lib/plugins/aws/deploy/tests/createStack.js +++ b/lib/plugins/aws/deploy/tests/createStack.js @@ -162,10 +162,6 @@ describe('createStack', () => { it('should resolve if no deploy', () => { awsDeploy.options.noDeploy = true; - const errorMock = { - message: 'does not exist', - }; - const writeCreateTemplateToDiskStub = sinon .stub(awsDeploy, 'writeCreateTemplateToDisk').returns(BbPromise.resolve()); const createStub = sinon diff --git a/lib/plugins/package/tests/zipService.js b/lib/plugins/package/tests/zipService.js index 6433a9dff..cbd374e4f 100644 --- a/lib/plugins/package/tests/zipService.js +++ b/lib/plugins/package/tests/zipService.js @@ -117,7 +117,6 @@ describe('#zipService()', () => { const unzippedFileData = unzippedData.files; // binary file is set with chmod of 777 - console.log(unzippedFileData['bin/some-binary']) expect(unzippedFileData['bin/some-binary'].unixPermissions) .to.equal(Math.pow(2, 15) + 777);