From 922ec0093f0d4ab6f2b2055c6e6f2d5ec1f9d06e Mon Sep 17 00:00:00 2001 From: Mariusz Nowak Date: Fri, 16 Jul 2021 10:18:21 +0200 Subject: [PATCH] fix: Fix `functions[]` validation (ignore `null` values) --- lib/classes/Service.js | 4 ++++ test/unit/lib/classes/Service.test.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/classes/Service.js b/lib/classes/Service.js index 235fafeb3..78a2a7cfb 100644 --- a/lib/classes/Service.js +++ b/lib/classes/Service.js @@ -211,6 +211,10 @@ class Service { ); } Object.entries(this.functions).forEach(([functionName, functionObj]) => { + if (functionObj == null) { + delete this.functions[functionName]; + return; + } if (!_.isObject(functionObj)) { throw new ServerlessError( `Unexpected "${functionName}" function configuration: Expected object received ${util.inspect( diff --git a/test/unit/lib/classes/Service.test.js b/test/unit/lib/classes/Service.test.js index 9b48d3232..f90e16aa8 100644 --- a/test/unit/lib/classes/Service.test.js +++ b/test/unit/lib/classes/Service.test.js @@ -135,7 +135,7 @@ describe('Service', () => { command: 'package', configExt: { functions: { - bar: null, + bar: true, }, }, })