archive-gh-me/serverless
1
0
Fork 0
mirror of https://github.com/serverless/serverless.git synced 2026-01-18 14:58:43 +00:00
Code Issues Projects Releases Wiki Activity

Remove validations for existence of compiledCloudFormationTemplate

Browse Source 
Because it's already available at the beginning of the deploy plugin as the core CloudFormation
template will be attached there (which is then used to merge other resources into it later on).
This commit is contained in:
Philipp Muens 2016-08-15 15:36:54 +02:00
parent 9fadb31d0b
commit 919caa8f91
10 changed files with 0 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js
View File

@ -5,11 +5,6 @@ const BbPromise = require('bluebird');
module.exports = {
validate() {
if (!this.serverless.service.provider.compiledCloudFormationTemplate) {
throw new this.serverless.classes
.Error('This plugin needs access to the compiled CloudFormation template');
}
// validate that path and method exists for each http event in service
_.forEach(this.serverless.service.functions, (functionObject, functionName) => {
functionObject.events.forEach(event => {

6
lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js
View File

@ -30,12 +30,6 @@ describe('#validate()', () => {
};
});
it('should throw an error if the compiled CloudFormation template is not available', () => {
awsCompileApigEvents.serverless.service.provider.compiledCloudFormationTemplate = false;
expect(() => awsCompileApigEvents.validate()).to.throw(Error);
});
it('should validate the http events "path" property', () => {
awsCompileApigEvents.serverless.service.functions = {
first: {

5
lib/plugins/aws/deploy/compile/events/s3/index.js
View File

@ -13,11 +13,6 @@ class AwsCompileS3Events {
}
compileS3Events() {
if (!this.serverless.service.provider.compiledCloudFormationTemplate) {
throw new this.serverless.classes
.Error('This plugin needs access to the compiled CloudFormation template');
}
this.serverless.service.getAllFunctions().forEach((functionName) => {
const functionObj = this.serverless.service.getFunction(functionName);

5
lib/plugins/aws/deploy/compile/events/s3/tests/index.js
View File

@ -21,11 +21,6 @@ describe('AwsCompileS3Events', () => {
});
describe('#compileS3Events()', () => {
it('should throw an error if the compiled CloudFormation template is not available', () => {
awsCompileS3Events.serverless.service.provider.compiledCloudFormationTemplate = false;
expect(() => awsCompileS3Events.compileS3Events()).to.throw(Error);
});
it('should throw an error if s3 event type is not a string or an object', () => {
awsCompileS3Events.serverless.service.functions = {
first: {

5
lib/plugins/aws/deploy/compile/events/schedule/index.js
View File

@ -13,11 +13,6 @@ class AwsCompileScheduledEvents {
}
compileScheduledEvents() {
if (!this.serverless.service.provider.compiledCloudFormationTemplate) {
throw new this.serverless.classes
.Error('This plugin needs access to the compiled CloudFormation template');
}
this.serverless.service.getAllFunctions().forEach((functionName) => {
const functionObj = this.serverless.service.getFunction(functionName);

5
lib/plugins/aws/deploy/compile/events/schedule/tests/index.js
View File

@ -21,11 +21,6 @@ describe('AwsCompileScheduledEvents', () => {
});
describe('#compileScheduledEvents()', () => {
it('should throw an error if the compiled CloudFormation template is not available', () => {
awsCompileScheduledEvents.serverless.service.provider.compiledCloudFormationTemplate = false;
expect(() => awsCompileScheduledEvents.compileScheduledEvents()).to.throw(Error);
});
it('should throw an error if schedule event type is not a string or an object', () => {
awsCompileScheduledEvents.serverless.service.functions = {
first: {

5
lib/plugins/aws/deploy/compile/events/sns/index.js
View File

@ -13,11 +13,6 @@ class AwsCompileSNSEvents {
}
compileSNSEvents() {
if (!this.serverless.service.provider.compiledCloudFormationTemplate) {
throw new this.serverless.classes
.Error('This plugin needs access to the compiled CloudFormation template');
}
this.serverless.service.getAllFunctions().forEach((functionName) => {
const functionObj = this.serverless.service.getFunction(functionName);

5
lib/plugins/aws/deploy/compile/events/sns/tests/index.js
View File

@ -20,11 +20,6 @@ describe('AwsCompileSNSEvents', () => {
});
describe('#compileSNSEvents()', () => {
it('should throw an error if the compiled CloudFormation template is not available', () => {
awsCompileSNSEvents.serverless.service.provider.compiledCloudFormationTemplate = false;
expect(() => awsCompileSNSEvents.compileSNSEvents()).to.throw(Error);
});
it('should throw an error if SNS event type is not a string or an object', () => {
awsCompileSNSEvents.serverless.service.functions = {
first: {

5
lib/plugins/aws/deploy/compile/functions/index.js
View File

@ -15,11 +15,6 @@ class AwsCompileFunctions {
}
compileFunctions() {
if (!this.serverless.service.provider.compiledCloudFormationTemplate) {
throw new this.serverless.classes
.Error('This plugin needs access to the compiled CloudFormation template');
}
// merge in the iamRoleLambdaTemplate
const iamRoleLambdaTemplate = this.serverless.utils.readFileSync(
path.join(this.serverless.config.serverlessPath,

5
lib/plugins/aws/deploy/compile/functions/tests/index.js
View File

@ -30,11 +30,6 @@ describe('AwsCompileFunctions', () => {
});
describe('#compileFunctions()', () => {
it('should throw an error if the compiled CloudFormation template is not available', () => {
awsCompileFunctions.serverless.service.provider.compiledCloudFormationTemplate = false;
expect(() => awsCompileFunctions.compileFunctions()).to.throw(Error);
});
it('should merge the IamRoleLambda template into the CloudFormation template', () => {
const iamRoleLambdaTemplate = awsCompileFunctions.serverless.utils.readFileSync(
path.join(