From 8717ff4c1c4973260634a565785f1ea4088716e8 Mon Sep 17 00:00:00 2001
From: My Ho <mydiemho@gmail.com>
Date: Mon, 9 Sep 2019 21:49:53 -0700
Subject: [PATCH] address pr comments: remove webpack plugin and clean up extra
 .gitignore

---
 .../create/templates/azure-nodejs/.gitignore  | 10 ----
 .../templates/azure-nodejs/serverless.yml     | 47 +++++++++----------
 2 files changed, 21 insertions(+), 36 deletions(-)
 delete mode 100644 lib/plugins/create/templates/azure-nodejs/.gitignore

diff --git a/lib/plugins/create/templates/azure-nodejs/.gitignore b/lib/plugins/create/templates/azure-nodejs/.gitignore
deleted file mode 100644
index 595924d48..000000000
--- a/lib/plugins/create/templates/azure-nodejs/.gitignore
+++ /dev/null
@@ -1,10 +0,0 @@
-# this is not the file that will be created with the template
-# this is to ignore file used when testing the template
-package-lock.json
-node_modules
-
-## offline testing
-local.settings.json
-
-## deploy testing
-.serverless/
diff --git a/lib/plugins/create/templates/azure-nodejs/serverless.yml b/lib/plugins/create/templates/azure-nodejs/serverless.yml
index 8d115f040..4c5095f7b 100644
--- a/lib/plugins/create/templates/azure-nodejs/serverless.yml
+++ b/lib/plugins/create/templates/azure-nodejs/serverless.yml
@@ -17,11 +17,6 @@ service: azure-nodejs # NOTE: update this with your service name
 # Check out our docs for more details
 # frameworkVersion: "=X.X.X"
 
-# if you are using webpack for packaging
-# custom:
-#   webpack:
-#     keepOutputDirectory: true
-
 provider:
   name: azure
   region: West US 2
@@ -36,18 +31,18 @@ provider:
 
   # you can define apim configuration here
   # apim:
-  #   api:
-  #     name: v1
-  #     subscriptionRequired: false
-  #     displayName: v1
-  #     description: V1 sample app APIs
-  #     protocols:
-  #       - https
-  #     path: v1
-  #     tags:
-  #       - tag1
-  #       - tag2
-  #     authorization: none
+  #   apis:
+  #     - name: v1
+  #       subscriptionRequired: false # if true must provide an api key
+  #       displayName: v1
+  #       description: V1 sample app APIs
+  #       protocols:
+  #         - https
+  #       path: v1
+  #       tags:
+  #         - tag1
+  #         - tag2
+  #       authorization: none
   #   cors:
   #     allowCredentials: false
   #     allowedOrigins:
@@ -63,30 +58,30 @@ provider:
   #     exposeHeaders:
   #       - "*"
 
-plugins:
+plugins: # look for additional plugins in the community plugins repo: https://github.com/serverless/plugins
   - serverless-azure-functions
-  # - serverless-webpack  # to use webpack for packaging code
 
 # you can add packaging information here
 package:
-  #  include:
-  #    - include-me.js
-  #    - include-me-dir/**
+  # include:
+  #   - include-me.js
+  #   - include-me-dir/**
   exclude:
-    #    - exclude-me.js
-    #    - exclude-me-dir/**
+    # - exclude-me.js
+    # - exclude-me-dir/**
     - local.settings.json
     - .vscode/**
 
 functions:
   hello:
-    handler: src/handlers/sayHello
+    handler: src/handlers/hello.sayHello
     events:
       - http: true
         x-azure-settings:
           methods:
             - GET
           authLevel: anonymous
+
   goodbye:
     handler: src/handlers/goodbye.sayGoodbye
     events:
@@ -134,7 +129,7 @@ functions:
   #         name: message # Specifies which name is available on `context`
   #         queueName: sample-queue # Name of the service bus queue to consume
   #         connection: SERVICE_BUS_CONNECTION # App Setting/environment variable variable which contains Service Bus Namespace Connection String
-  #  serviceBusTopic:
+  # serviceBusTopic:
   #   handler: src/handlers/serviceBusTopic.printMessage
   #   events:
   #     - serviceBus: