From 70e27362260f97b68bb1dfaf52fa3fe7877a2adc Mon Sep 17 00:00:00 2001 From: Mariusz Nowak Date: Thu, 7 Oct 2021 11:58:52 +0200 Subject: [PATCH] feat(Packaging): Remove `package[include|exclude]` deprecation It'll be re-added in context of v3 --- docs/deprecations.md | 2 ++ lib/plugins/package/package.js | 19 ------------------- 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/docs/deprecations.md b/docs/deprecations.md index 42c6079b8..5b4c43b96 100644 --- a/docs/deprecations.md +++ b/docs/deprecations.md @@ -104,6 +104,8 @@ Starting with v3.0.0 any option extensions which does not have `type` defined wi Deprecation code: `NEW_PACKAGE_PATTERNS` +_Note: We've resigned from this deprecation in the context of v2 (it'll be re-added in the context of v3). We continue to advise upgrade of services, so they do not rely on `package.include` and `package.exclude` settings._ + Support for `package.include` and `package.exclude` will be removed with v3.0.0. Instead please use `package.patterns` with which both _include_ and _exclude_ (prefixed with `!`) rules can be configured. Check [Packaging Patterns](/framework/docs/providers/aws/guide/packaging/#patterns) documentation for more info. diff --git a/lib/plugins/package/package.js b/lib/plugins/package/package.js index 5a432ef1d..20ad625d1 100644 --- a/lib/plugins/package/package.js +++ b/lib/plugins/package/package.js @@ -33,25 +33,6 @@ class Package { }; this.hooks = { - 'initialize': () => { - const useIncludeExclude = (packageConfig = {}) => - packageConfig.include || packageConfig.exclude; - const servicePackage = this.serverless.service.package || {}; - if ( - useIncludeExclude(servicePackage) || - Object.values(this.serverless.service.functions).some((func) => - useIncludeExclude(func.package) - ) || - Object.values(this.serverless.service.layers || {}).some((func) => - useIncludeExclude(func.package) - ) - ) { - this.serverless._logDeprecation( - 'NEW_PACKAGE_PATTERNS', - 'Support for "package.include" and "package.exclude" will be removed with next major release. Please use "package.patterns" instead' - ); - } - }, 'package:createDeploymentArtifacts': async () => BbPromise.bind(this).then(this.packageService),